Consistent Breakpoints in Theme #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs-variable imports into common/variables. Changed $screen-xs-max value to $breakpoint-mobile-max and $screen-sm-min value to $breakpoint-mobile-min. J=SLAP-1277 TEST=manual Built the test site and checked on Chrome and IE11 for any unusual activity with varying window sizes.
…-mobile-min instead of screen-xs-max and screen-sm-min
oshi97
reviewed
Jun 18, 2021
| @@ -9,8 +9,8 @@ $vertical-margin-top: $grid-gutter-width !default; | |||
| $vertical-margin-bottom: $grid-gutter-width !default; | |||
|
|
|||
| $screen-xs-min: 480px; | |||
| $screen-xs-max: 767px; | |||
| $screen-sm-min: 768px; | |||
| $screen-xs-max: 768px; | |||
There was a problem hiding this comment.
did we mean to change screen-xs-max from 767 to 768?
There was a problem hiding this comment.
no, but it doesn't make a difference because we are no longer using those values in utilitymixins. I'll change it back though just for more clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed most @media to @include breakpoints instead. Also moved answers-variable imports into common/variables. Changed $screen-xs-max value to $breakpoint-mobile-max and $screen-sm-min value to $breakpoint-mobile-min.
J=SLAP-1277
TEST=manual
Built the test site and checked on Chrome and IE11 for any unusual activity with varying window sizes.