use isAbsoluteUrl helper to determine absolute urls #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use isAbsoluteUrl helper to determine absolute urls This commit adds the isAbsoluteUrl helper to determine urls, and updates the regex we were using to also detect urls of the mailto:slapshot@gmail.com. In order to use this helper outside of templates sent to the SDK, this helper also had to be added to jambo, and the jambo version incremented to 1.9.0. When we implement custom hbs helpers in jambo, this helper should be moved fully to the hitchhiker theme. J=SLAP-861 TEST=manual test that urls like //yext.com will still be recognized as absolute test using a data:image/gif;base64, url for favicon (uses jambo helper) test using a mailto: link inside the professional location card
yeah just had to remove some remove some other changes and update the regex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the isAbsoluteUrl helper to determine urls,
and updates the regex we were using to also detect urls of the
mailto:slapshot@gmail.com. It cherrypicks #475
TEST=manual
test that I can build a vertical standard page