Default universal section title to vertical's displayName.
#493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the `JAMBO_INJECTED_DATA` was updated so that the `displayName` of each vertical in an experience is provided. We should default to this name when constructing the vertical's universal section template. As before, if a `label` or `secionTitleName` has been specified in page configuration, we will favor those instead. J=SLAP-887 TEST=manual Tested the following: - Set a `label` for a vertical, verified that was used as the section title. - Set a `sectionTitleName` for a vertical, verified that was used as the section title. - When no `label` or `sectionTitleName` was present, saw the `displayName` from the injected data used as the section title. - If no `diplsayName` was present for the vertical, saw it's `verticalKey` used as the section title.
nanhu95
reviewed
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the
JAMBO_INJECTED_DATAwas updated so that thedisplayNameofeach vertical in an experience is provided. We should default to this name
when constructing the vertical's universal section template. As before, if
a
labelorsecionTitleNamehas been specified in page configuration, wewill favor those instead.
J=SLAP-887
TEST=manual
Tested the following:
labelfor a vertical, verified that was used as the section title.sectionTitleNamefor a vertical, verified that was used as thesection title.
labelorsectionTitleNamewas present, saw thedisplayNamefromthe injected data used as the section title.
diplsayNamewas present for the vertical, saw it'sverticalKeyusedas the section title.