Add CSS variable ponyfill to the button iframe #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexisgrow
commented
Nov 23, 2020
| <script src="overlay-button.js"></script> | ||
| <link rel="stylesheet" type="text/css" href="overlay-button.css"> |
There was a problem hiding this comment.
Ponyfill must be imported before the CSS variable filled styling 👾
tmeyer2115
reviewed
Nov 23, 2020
tmeyer2115
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CSS variable ponyfill lives in the Answers SDK. Since we don't use the Answers SDK in the button iframe, our variables were not being ponyfilled which meant that they weren't working in IE11. Add the ponyfill to the button iframe's JS.
TEST=manual
J=PB-9812
Serve page in IE11, see font family is font family specified in the answers-variables file rather than the default IE11 font.