Version 1.34.0 #1187
Merged
Version 1.34.0 #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map * Implement playwright acceptance tests for vertical full page map
Merge master (v1.33.2) into develop
Merge master (v1.33.3) into develop
Merge master (v1.33.4) into develop
Merge master (v1.33.5) into develop
Merge master (v1.33.6) into develop
Merge master (v1.33.7) into develop
This change updates the image handling to accommodate all image url formats before, during and after the image url change. Related thread: https://yext.slack.com/archives/C0DA5HJCT/p1713445795909829 J=WAT-3980 TEST=auto, manual Ran npm run test. Manually copied my change to two answers experience (one in US and one in EU). Confirmed the images in both experiences loads fine in Live Preview.
nmanu1
reviewed
May 9, 2024
nmanu1
reviewed
May 9, 2024
There was a problem hiding this comment.
Can you include the PR number in the change description?
Also, the release notes are intended for customers and should be phrased accordingly. For example, a customer wouldn't understand what "the image url change" is and would probably not care much about the format of the URL. Something like this would be more relevant for them:
- Updated the image formatter to return a fully dynamically-sized image instead of the closest thumbnail out of a fixed set (#1184)
nmanu1
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes