Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump answers-search-ui version to 1.17 #1170

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Feb 20, 2024

Bump answers-search-ui version to 1.17 to get the change for switching icon divs to spans

@coveralls
Copy link

Coverage Status

coverage: 9.35%. remained the same
when pulling e8a7a37 on dev/bump-sdk-1.17
into 1d2d07d on hotfix/v1.33.5.

@nmanu1 nmanu1 merged commit 8c7ce66 into hotfix/v1.33.5 Feb 20, 2024
15 of 16 checks passed
@nmanu1 nmanu1 deleted the dev/bump-sdk-1.17 branch February 20, 2024 15:36
@nmanu1 nmanu1 mentioned this pull request Feb 20, 2024
nmanu1 added a commit that referenced this pull request Feb 20, 2024
### Fixes
- Resolve vulnerabilities (#1167)
- Remove `span` styling and bump answers-search-ui version to 1.17 so icon `div`s are changed to `span`s without affecting their styling (#1169, #1170)
  - Note, any custom styling that is applied by targeting `div`s or `span`s directly may be impacted by this change. This could result in previously applied styles no longer being applied to these icons, or other styles inadvertently being applied to the icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants