Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EU-Served Images #1163

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Handle EU-Served Images #1163

merged 2 commits into from
Jan 18, 2024

Conversation

EmilyZhang777
Copy link
Contributor

This PR makes sure EU-served images are handled properly since they have a different format than US-served images.

J=TECHOPS-10895
TEST=auto,manual

Added and ran jest tests.
Manually checked out pages with EU and US-served images and made sure they all show up correctly.

@EmilyZhang777 EmilyZhang777 requested a review from a team January 16, 2024 19:50
@coveralls
Copy link

coveralls commented Jan 16, 2024

Coverage Status

coverage: 9.317% (+0.6%) from 8.737%
when pulling 3e6284f on dev/handle-eu-images
into f2d3f2b on master.

benmcginnis
benmcginnis previously approved these changes Jan 18, 2024
Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once you change the base branch!

@EmilyZhang777 EmilyZhang777 changed the base branch from master to hotfix/v1.33.4 January 18, 2024 18:31
@EmilyZhang777 EmilyZhang777 merged commit 67c1eee into hotfix/v1.33.4 Jan 18, 2024
15 of 16 checks passed
@EmilyZhang777 EmilyZhang777 mentioned this pull request Jan 18, 2024
@EmilyZhang777 EmilyZhang777 deleted the dev/handle-eu-images branch January 18, 2024 19:28
EmilyZhang777 added a commit that referenced this pull request Jan 18, 2024
### Fixes
- Makes sure images served from EU are properly handled (#1163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants