Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.33.2 #1157

Merged
merged 4 commits into from
Dec 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .github/run_browserstack_acceptance.sh

This file was deleted.

39 changes: 0 additions & 39 deletions .github/workflows/acceptance_browserstack.yml

This file was deleted.

31 changes: 31 additions & 0 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Playwright Tests

on:
push:
branches-ignore: dev/*

jobs:
test:
timeout-minutes: 60
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
- name: Install dependencies
run: npm ci
- name: Install Playwright Browsers
run: npx playwright install --with-deps
- name: Setup test site
run: npm run setup-test-site
- name: Build test site
run: npm run build-test-site
- name: Run playwright tests
run: npx playwright test
- uses: actions/upload-artifact@v3
if: always()
with:
name: playwright-report
path: playwright-report/
retention-days: 30
6 changes: 5 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,8 @@ static/node_modules/
static/dist/
node_modules
**/.DS_Store
.idea/
.idea/
/test-results/
/playwright-report/
/blob-report/
/playwright/.cache/
135 changes: 135 additions & 0 deletions e2e/vertical-full-page-map.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
import { test, expect } from '@playwright/test';

async function waitForResultsToLoad(page) {
const result = page.locator('#js-answersVerticalResults div').nth(0);
await expect(result).toBeAttached();
}

test.describe('full page map test suite', () => {
test.beforeEach(async ({page}) => {
await page.goto('http://localhost:5042/locations_full_page_map');
});

test('can search and get results', async ({ page }) => {
await page.waitForResponse(resp =>
resp.url().includes('https:\/\/prod-cdn\.us\.yextapis\.com\/v2\/accounts\/me\/search\/vertical\/query')
&& resp.url().includes('queryTrigger'));
const prevResultsCount = await page.locator('.yxt-VerticalResultsCount-total').textContent();

await page.getByPlaceholder('Search for locations').fill('virginia');
await page.getByPlaceholder('Search for locations').press('Enter');
await page.waitForResponse(resp =>
resp.url().includes('https:\/\/prod-cdn\.us\.yextapis\.com\/v2\/accounts\/me\/search\/vertical\/query')
&& resp.url().includes('input=virginia'));
const resultsCount = await page.locator('.yxt-VerticalResultsCount-total').textContent();

expect(prevResultsCount).not.toBe(resultsCount);
});

test('clicking on a pin focuses on a result card', async ({ page }) => {
await expect(page.locator('.yxt-Card--pinFocused')).not.toBeAttached();
await page.getByRole('button', { name: 'Result number 13' }).click();
await expect(page.locator('.yxt-Card--pinFocused')).toBeAttached();
});

test('search when map moves works', async ({ page }) => {
await page.getByPlaceholder('Search for locations').fill('virginia');
await page.getByPlaceholder('Search for locations').press('Enter');
await waitForResultsToLoad(page);
const map = page.locator('.mapboxgl-canvas');
await map.dragTo(map, {
sourcePosition: { x: 788, y: 345},
targetPosition: { x: 1011, y: 225},
})
const response = await page.waitForResponse(resp =>
resp.url().includes('https:\/\/prod-cdn\.us\.yextapis\.com\/v2\/accounts\/me\/search\/vertical\/query')
&& resp.url().includes('radius'));
expect(response.status()).toBe(200);
});

test('search this area button works', async ({ page }) => {
await page.getByLabel('Map controls').getByText('Search When Map Moves').click();
await page.getByPlaceholder('Search for locations').fill('virginia');
await page.getByPlaceholder('Search for locations').press('Enter');
await page.waitForResponse(resp =>
resp.url().includes('https:\/\/prod-cdn\.us\.yextapis\.com\/v2\/accounts\/me\/search\/vertical\/query')
&& !resp.url().includes('radius'));
await page.locator('div').filter({ hasText: /^Search This Area$/ }).nth(1).click();
const response = await page.waitForResponse(resp =>
resp.url().includes('https:\/\/prod-cdn\.us\.yextapis\.com\/v2\/accounts\/me\/search\/vertical\/query')
&& resp.url().includes('radius'));
expect(response.status()).toBe(200);
});

test('default initial search works and is enabled by default', async ({ page }) => {
const response = await page.waitForResponse(resp =>
resp.url().includes('https:\/\/prod-cdn\.us\.yextapis\.com\/v2\/accounts\/me\/search\/vertical\/query')
&& resp.url().includes('queryTrigger'));
expect(response.status()).toBe(200);
});

test('empty search works', async ({ page }) => {
await page.getByPlaceholder('Search for locations').press('Enter');
const response = await page.waitForResponse(resp =>
resp.url().includes('https:\/\/prod-cdn\.us\.yextapis\.com\/v2\/accounts\/me\/search\/vertical\/query')
&& resp.url().includes('input=&'));
expect(response.status()).toBe(200);
})

test('pagination works', async ({ page }) => {
const resultsCount = page.locator('#js-answersVerticalResultsCount');
await expect(resultsCount).toHaveText(/20/);
await page.getByLabel('Go to the next page of results').click();
await expect(resultsCount).toHaveText(/21/);
});

test('pagination scrolls the results to the top', async ({ page }) => {
await page.evaluate(() => window.scrollTo(0, document.documentElement.scrollHeight));

const scrollOffsetBeforePagination = await page.evaluate(() => {return window.scrollY});
expect(scrollOffsetBeforePagination).not.toBe(0);

await page.getByLabel('Go to the next page of results').click();
await waitForResultsToLoad(page);

const scrollOffsetAfterPagination = await page.evaluate(() => {return window.scrollY});
expect(scrollOffsetAfterPagination).toBe(0);
});

});

test.describe('full page map with filters test suite', () => {
test.beforeEach(async ({page}) => {
await page.goto('http://localhost:5042/locations_full_page_map_with_filters');
});

test('clicking on a pin closes the filter view', async ({ page }) => {
await page.getByRole('button', { name: 'filter results' }).click();
const filters = page.locator('#js-answersFacets');
await expect(filters).toBeVisible();
await page.getByRole('button', { name: 'Result number 7' }).click();
await expect(filters).not.toBeVisible();
});

test('clicking on a cluster causes the map to zoom in and new search is ran', async ({ page }) => {
await page.getByPlaceholder('Search for locations').fill('virginia');
await page.getByPlaceholder('Search for locations').press('Enter');
await page.waitForResponse(resp => resp.url().includes('https://prod-cdn.us.yextapis.com/v2/accounts/me/search/vertical/query')
&& resp.url().includes('input=virginia')
&& !resp.url().includes('filters'));

await waitForResultsToLoad(page);

const originalCount = await page.locator('.yxt-Card').count();

await page.getByRole('button', { name: 'Cluster of 2 results' }).click();
await page.waitForResponse(resp => resp.url().includes('https://prod-cdn.us.yextapis.com/v2/accounts/me/search/vertical/query')
&& resp.url().includes('input=virginia')
&& resp.url().includes('filters'));

await waitForResultsToLoad(page);

const countAfterSelectingCluster = await page.locator('.yxt-Card').count();
expect(originalCount).toBeGreaterThan(countAfterSelectingCluster);
});
});
Loading