pass Client-SDK HTTP header #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will only work when pointed to the next version of the SDK. J=SLAP-1949 TEST=manual,auto see that the test-site specifies the theme's version in the header create a fresh jambo site using the hitchhiker theme, see the header passed as expected
oshi97
force-pushed
the
dev/pass-client-sdk
branch
from
65af9fa
to
9fd42c3
Compare
oshi97
force-pushed
the
dev/pass-client-sdk
branch
from
9fd42c3
to
f2df1ac
Compare
yen-tt
reviewed
Mar 17, 2022
yen-tt
reviewed
Mar 17, 2022
yen-tt
reviewed
Mar 17, 2022
| VERTICAL_AUTOCOMPLETE_URL_REGEX | ||
| } from '../constants'; | ||
| import { SearchRequestLogger } from '../searchrequestlogger'; | ||
| import { } from '../constants'; |
yen-tt
reviewed
Mar 17, 2022
| const universalAutocompleteLogger = (new SearchRequestLogger()).createUniversalAutocompleteLogger(); | ||
|
|
||
| fixture`Client-SDK header works on universal searches/autocomplete` | ||
| .page(`http://localhost:${PORT}/index`) |
There was a problem hiding this comment.
small thing, do we need to specify index? or does it work without it
yen-tt
approved these changes
Mar 17, 2022
Merged
nmanu1
added a commit
that referenced
this pull request
May 10, 2022
## Version 1.29.0 ### Features - Added support for passing Answers Agents in the HTTP header (#1056) - Added support for adding custom autocomplete prompts (#1040) - Added RTF truncation support (#1060, #1061) ### Changes - Updated default `vertical-grid` universal limit to 3 (#1048) ### Bug Fixes - Fixed filters and footer overlap on desktop view (#806) - Fixed `CollapsibleFilters` tab order (#1057) - Fixed text truncation in the accordion card (#1065) - Updated iframe tab navigation to keep parent’s domain (#1067)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only work when pointed to the next version of the SDK.
J=SLAP-1949
TEST=manual,auto
see that the test-site specifies the theme's version in the header
create a fresh jambo site using the hitchhiker theme, see the header passed as expected