v1.28.1 #1050
Merged
v1.28.1 #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a result's internal `uid` instead of the external entity `id` for identifying map pins. The `id` can be any string specified by the user. This causes an error when clicking on a map pin on mobile if the `id` has spaces, apostrophes, etc. The `uid` is a unique, automatically-generated string that only consists of numbers, so it would not have this problem. J=SLAP-1962 TEST=manual Check that map pins on mobile can now be clicked regardless of external entity ID because the `uid` is used instead.
tmeyer2115
previously approved these changes
Mar 9, 2022
oshi97
previously approved these changes
Mar 9, 2022
Add patch file for changing the map pin to use `uid` instead of `id` (based on PR #1049). J=SLAP-1962 TEST=manual Test that the patch was applied successfully on a site using Theme 1.26.
tmeyer2115
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes