Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor global config merging strategy on upgrade #1031

Merged
merged 8 commits into from
Jan 6, 2022

Commits on Jan 5, 2022

  1. refactor global config merging strategy on upgrade

    This commit refactors how global configs are merged on theme upgrades.
    Now, global configs will always have the same "structure" as the incoming
    config, instead of sometimes placing properties in seemingly random spots,
    if the two configs don't match up exactly in terms of structure.
    
    Per Rose's request, the sdkVersion is now always updated to the incoming
    config's value. Besides that, preexisting properties will favor the
    original config, while commented out properties will favor the incoming config.
    
    Properties and comments in the original that do no exist in the incoming config
    will be moved to the bottom of the config.
    
    J=SLAP-1717
    TEST=manual,auto
    
    ran an upgrade
    oshi97 committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    04340fc View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. fix'

    oshi97 committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    0ad9577 View commit details
    Browse the repository at this point in the history
  2. eslint

    oshi97 committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    f0c3548 View commit details
    Browse the repository at this point in the history
  3. update ignorePatterns

    oshi97 committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    fbbed37 View commit details
    Browse the repository at this point in the history
  4. refactor for each loops

    oshi97 committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    d482a0c View commit details
    Browse the repository at this point in the history
  5. consolidate method

    oshi97 committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    3695347 View commit details
    Browse the repository at this point in the history
  6. { SwitchCase: 1 }

    oshi97 committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    fc85eb5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    162c99a View commit details
    Browse the repository at this point in the history