Testcafe Fixes #1024
Merged
Testcafe Fixes #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeyer2115
approved these changes
Dec 14, 2021
oshi97
reviewed
Dec 14, 2021
package.json
Outdated
| @@ -47,7 +47,7 @@ | |||
| "puppeteer": "^10.2.0", | |||
| "serve": "^11.3.2", | |||
| "simple-git": "^2.24.0", | |||
| "testcafe": "^1.15.0", | |||
| "testcafe": "^1.17.0", | |||
There was a problem hiding this comment.
Based on the package-lock, it looks like 1.17.1 is the version which is actually being used. I can bump it here as well just to be safe
tmeyer2115
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Testcafe errors in safari by bumping the Testcafe version number
This PR fixes the "undefined is not an object (evaluating 'qa.objectHasOwnProperty.call(s,"writable")') hasOwnProperty@[native code]" error which was occurring in Testcafe on Safari.
Also fix the path to the testcafe config file.
J=none
TEST=none
Run the acceptance tests and see that they now pass