Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update escape packages #1014

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Update escape packages #1014

merged 4 commits into from
Nov 29, 2021

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented Nov 29, 2021

  • update escape-html to be devDependency in top level package
  • add escape-html as depeendency in static package

Update escape packages
dc745dc 
- update escape-html to be devDependency in top level package
- add escape-html as depeendency in static package
@coveralls
Copy link

coveralls commented Nov 29, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 8.844% when pulling c560100 on dev/update-package into ab4dfe8 on develop.

oshi97
oshi97 reviewed Nov 29, 2021
View reviewed changes
static/package-lock.json Outdated
@@ -1,8 +1,9479 @@
{
"name": "answers-hitchhiker-theme",
"version": "1.26.0",
"lockfileVersion": 1,
"lockfileVersion": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want to change the lockfile ver until we're sure the CBD containers can handle it

@yen-tt yen-tt requested a review from oshi97 November 29, 2021 20:04
@oshi97
Copy link
Contributor

oshi97 commented Nov 29, 2021

think the original lockfile was deleted by accident

@yen-tt
Copy link
Contributor Author

yen-tt commented Nov 29, 2021 •
edited
Loading

think the original lockfile was deleted by accident

oh it's just a lot of changes since I was changed it to lockfile version 1 along with the static package lock. the file is still there

@yen-tt yen-tt merged commit 2b71bfd into develop Nov 29, 2021
@yen-tt yen-tt deleted the dev/update-package branch November 29, 2021 22:48
@saurabhaditya saurabhaditya mentioned this pull request Sep 3, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshi97 oshi97 oshi97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yen-tt @coveralls @oshi97