Skip to content

Commit

Permalink
Merge pull request #512 from yext/master-into-1.17
Browse files Browse the repository at this point in the history
Merge master into release/v1.17 and resolve conflicts.

Also, update the package version numbers and incorporate #503

J=none
Test=none
  • Loading branch information
cea2aj authored Dec 1, 2020
2 parents 230c9d7 + e9e8922 commit 1949ef2
Show file tree
Hide file tree
Showing 9 changed files with 24 additions and 16 deletions.
9 changes: 6 additions & 3 deletions cards/financial-professional-location/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
{{#*inline 'image'}}
{{#if card.image}}
<div class="HitchhikerFinancialProfessionalLocation-imgWrapper">
<img class="HitchhikerFinancialProfessionalLocation-img" src="{{card.image}}" alt="{{#if card.altText}}{{card.altText}}{{/if}}" />
<img class="HitchhikerFinancialProfessionalLocation-img"
src="{{#unless (isAbsoluteUrl card.image)}}{{relativePath}}/{{/unless}}{{card.image}}"
alt="{{#if card.altText}}{{card.altText}}{{/if}}" />
</div>
{{/if}}
{{/inline}}
Expand All @@ -41,7 +43,8 @@
{{#if card.title}}
<div class="HitchhikerFinancialProfessionalLocation-title">
{{#if card.url}}
<a class="HitchhikerFinancialProfessionalLocation-titleLink js-HitchhikerFinancialProfessionalLocation-titleLink" href="{{card.url}}"
<a class="HitchhikerFinancialProfessionalLocation-titleLink js-HitchhikerFinancialProfessionalLocation-titleLink"
href="{{#unless (isAbsoluteUrl card.url}}{{relativePath}}/{{/unless}}{{card.url}}"
data-eventtype="TITLE_CLICK" data-eventoptions='{{json card.titleEventOptions}}'
target={{#if card.target}}"{{card.target}}"{{else}}"_top" rel="noopener noreferrer nofollow" {{/if}}>
{{card.title}}
Expand Down Expand Up @@ -159,7 +162,7 @@
{{#if (all url label)}}
<div class="HitchhikerFinancialProfessionalLocation-{{ctaName}}">
<a class="HitchhikerCTA js-HitchhikerCTA{{#if modifiers}} {{modifiers}}{{/if}}"
href="{{url}}"
href="{{#unless (isAbsoluteUrl url)}}{{relativePath}}/{{/unless}}{{url}}"
data-eventtype="{{eventType}}"
data-eventoptions='{{json eventOptions}}'
target="{{#if target}}{{target}}{{else}}_top{{/if}}"
Expand Down
6 changes: 4 additions & 2 deletions cards/location-standard/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@
{{#if card.title}}
<div class="HitchhikerLocationStandard-title">
{{#if card.titleUrl}}
<a class="HitchhikerLocationStandard-titleLink js-Hitchhiker-title" href="{{card.titleUrl}}" data-eventtype="TITLE_CLICK"
<a class="HitchhikerLocationStandard-titleLink js-Hitchhiker-title"
href="{{#unless (isAbsoluteUrl card.titleUrl)}}{{relativePath}}/{{/unless}}{{card.titleUrl}}"
data-eventtype="TITLE_CLICK"
data-eventoptions='{{json card.titleEventOptions}}'
target={{#if card.target}}"{{card.target}}"{{else}}"_top"{{/if}}>
{{{card.title}}}
Expand Down Expand Up @@ -191,4 +193,4 @@
{{/if}}
</div>
{{/if}}
{{/inline}}
{{/inline}}
9 changes: 6 additions & 3 deletions cards/multilang-financial-professional-location/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
{{#*inline 'image'}}
{{#if card.image}}
<div class="HitchhikerFinancialProfessionalLocation-imgWrapper">
<img class="HitchhikerFinancialProfessionalLocation-img" src="{{card.image}}" alt="{{#if card.altText}}{{card.altText}}{{/if}}" />
<img class="HitchhikerFinancialProfessionalLocation-img"
src="{{#unless (isAbsoluteUrl card.image)}}{{relativePath}}/{{/unless}}{{card.image}}"
alt="{{#if card.altText}}{{card.altText}}{{/if}}" />
</div>
{{/if}}
{{/inline}}
Expand All @@ -41,7 +43,8 @@
{{#if card.title}}
<div class="HitchhikerFinancialProfessionalLocation-title">
{{#if card.url}}
<a class="HitchhikerFinancialProfessionalLocation-titleLink js-HitchhikerFinancialProfessionalLocation-titleLink" href="{{card.url}}"
<a class="HitchhikerFinancialProfessionalLocation-titleLink js-HitchhikerFinancialProfessionalLocation-titleLink"
href="{{#unless (isAbsoluteUrl card.url)}}{{relativePath}}/{{/unless}}{{card.url}}"
data-eventtype="TITLE_CLICK" data-eventoptions='{{json card.titleEventOptions}}'
target={{#if card.target}}"{{card.target}}"{{else}}"_top" rel="noopener noreferrer nofollow" {{/if}}>
{{card.title}}
Expand Down Expand Up @@ -159,7 +162,7 @@
{{#if (all url label)}}
<div class="HitchhikerFinancialProfessionalLocation-{{ctaName}}">
<a class="HitchhikerCTA js-HitchhikerCTA{{#if modifiers}} {{modifiers}}{{/if}}"
href="{{url}}"
href="{{#unless (isAbsoluteUrl url)}}{{relativePath}}/{{/unless}}{{url}}"
data-eventtype="{{eventType}}"
data-eventoptions='{{json eventOptions}}'
target="{{#if target}}{{target}}{{else}}_top{{/if}}"
Expand Down
6 changes: 4 additions & 2 deletions cards/multilang-location-standard/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@
{{#if card.title}}
<div class="HitchhikerLocationStandard-title">
{{#if card.titleUrl}}
<a class="HitchhikerLocationStandard-titleLink js-Hitchhiker-title" href="{{card.titleUrl}}" data-eventtype="TITLE_CLICK"
<a class="HitchhikerLocationStandard-titleLink js-Hitchhiker-title"
href="{{#unless (isAbsoluteUrl card.titleUrl)}}{{relativePath}}/{{/unless}}{{card.titleUrl}}"
data-eventtype="TITLE_CLICK"
data-eventoptions='{{json card.titleEventOptions}}'
target={{#if card.target}}"{{card.target}}"{{else}}"_top"{{/if}}>
{{{card.title}}}
Expand Down Expand Up @@ -191,4 +193,4 @@
{{/if}}
</div>
{{/if}}
{{/inline}}
{{/inline}}
2 changes: 0 additions & 2 deletions global_config.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
{
"sdkVersion": "1.6", // The version of the Answers SDK to use
// "apiKey": "<REPLACE ME>", // The answers api key found on the experiences page. This will be provided automatically by the Yext CI system
"experienceKey": "<REPLACE ME>",
// "experienceVersion": "<REPLACE ME>", // the Answers Experience version to use for API requests. This will be provided automatically by the Yext CI system
// "businessId": "<REPLACE ME>", // The business ID of the account. This will be provided automatically by the Yext CI system
"locale": "en", // The default locale for searches. Examples: UK: en-GB, Spanish: es, Spain Spanish: es-ES.
"logo": "", // The link to the logo for open graph meta tag - og:image.
"favicon": "",
"googleTagManagerName": "dataLayer", // The name of your Google Tag Manager data layer
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "answers-hitchhiker-theme",
"version": "1.16.0",
"version": "1.17.0",
"description": "A starter answers theme for hitchhikers",
"scripts": {
"test": "cross-env NODE_ICU_DATA=node_modules/full-icu jest --verbose"
Expand Down
2 changes: 1 addition & 1 deletion static/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion static/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "answers-hitchhiker-theme",
"version": "1.16.0",
"version": "1.17.0",
"description": "Toolchain for use with the HH Theme",
"main": "Gruntfile.js",
"scripts": {
Expand Down

0 comments on commit 1949ef2

Please sign in to comment.