Enable clippy in CI

.travis.yml

@@ -28,6 +28,7 @@ rust:
 install:
   - nvm install 9
   - rustup component add rustfmt
+  - rustup component add clippy
   - rustup target add wasm32-unknown-unknown
   - cargo install cargo-update || true
   - cargo install-update-config --version =0.2.50 wasm-bindgen-cli
@@ -38,6 +39,5 @@ install:
   - ./ci/install_cargo_web.sh
 
 script:
-  - rustup target list --installed
-  - cargo fmt --all -- --check
+  - ./ci/run_checks.sh
   - CHROMEDRIVER=$(pwd)/chromedriver ./ci/run_tests.sh

ci/run_checks.sh

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+
+echo "$(rustup default)" | grep -q "stable"
+if [ "$?" != "0" ]; then
+  # only run checks on stable rust for stability
+  exit 0
+fi
+
+set -euxo pipefail
+cargo fmt --all -- --check
+cargo clippy -- --deny=warnings

src/html/mod.rs

@@ -234,9 +234,12 @@ impl<T> ChildrenRenderer<T> {
 
 impl<T> Default for ChildrenRenderer<T> {
     fn default() -> Self {
+        // False positive: https://github.com/rust-lang/rust-clippy/issues/4002
+        #[allow(clippy::redundant_closure)]
+        let boxed_render = Box::new(|| Vec::new());
         Self {
             len: 0,
-            boxed_render: Box::new(|| Vec::new()),
+            boxed_render,
         }
     }
 }

src/services/fetch.rs

@@ -345,6 +345,7 @@ where
         callback.emit(response);
     };
 
+    #[allow(clippy::too_many_arguments)]
     let handle = js! {
         var body = @{body};
         if (@{binary} && body != null) {

src/virtual_dom/vnode.rs

@@ -8,6 +8,7 @@ use std::iter::FromIterator;
 use stdweb::web::{Element, INode, Node};
 
 /// Bind virtual element to a DOM reference.
+#[allow(clippy::large_enum_variant)] // ISSUE: #571
 pub enum VNode<COMP: Component> {
     /// A bind between `VTag` and `Element`.
     VTag(VTag<COMP>),

src/virtual_dom/vtag.rs

@@ -516,7 +516,7 @@ impl<COMP: Component> PartialEq for VTag<COMP> {
             && self.attributes == other.attributes
             && self.classes.set.len() == other.classes.set.len()
             && self.classes.set.iter().eq(other.classes.set.iter())
-            && &self.children == &other.children
+            && self.children == other.children
     }
 }