Box VTag to reduce size disparity between VNode variants #675

hgzimmerman · 2019-09-30T17:19:04Z

fixes #571

(breaking change)

jstarry · 2019-10-13T19:33:35Z

Thanks @hgzimmerman! Looks like the clippy warning was complaining about VTag not VComp though 😉

hgzimmerman · 2019-10-13T21:51:07Z

Wow, missed that one, ~~will update with the appropriate change~~.

This is a little harder than it appeared at first glance, I'll take some time and see if I can come up with a satisfactory change.

~~As things are right now, the performance benefits of moving a smaller item into a function by boxing a variant may be dwarfed by the large amount of boxing/unboxing that will have to be done.~~

It may make sense to delay this change until benchmarks exist so that the effect of this change can be verified to be a positive one.

Edit:
For whatever reason, I figured the refactoring I needed to do would result in many allocations/deallocations. It doesn't add any more beyond the initial VTag allocation needed now. I think my statement about measuring performance before merging is still relevant.

crates/macro/src/html_tree/html_tag/mod.rs

jstarry · 2019-10-14T22:07:07Z

Looks good! Can you please rebase though and remove the clippy allow I added recently? I also enabled clippy in CI so we can verify that this fix passes CI 😄

Fixes yewstack#685 Address deprecations warnings in the examples directory: warning: trait objects without an explicit `dyn` are deprecated

* Bump wasm-bindgen to 0.2.50 * Update Cargo.toml * Update Cargo.toml

* childs -> children * precursor -> previous_sibling * cargo fmt and name changes

* Optimize the default `change` implementation Return `false` if `Self::Properties` has a value of `()`. * Use TypeId for checking Properties == ()

* Forbid missing debug implementations * someday I'll remember to run cargo fmt before pushing the first time * add debug for other format types * derive debug for HandlerId

* Rework travis cache and fix cargo-update * Split examples out of main workspace

* Use wasm32-unknown-unknown as the default build target * Print rustup installed targets * Add doc_test alias

* Enable clippy in CI * Fix clippy warnings * Only run fmt and clippy on stable * Fix check script

Box VComp to reduce size disparity between VNode variants

6f8d07a

jstarry added the breaking change label Sep 30, 2019

hgzimmerman changed the title ~~Box VComp to reduce size disparity between VNode variants~~ Box VTag to reduce size disparity between VNode variants Oct 13, 2019

hgzimmerman added 5 commits October 13, 2019 20:16

revert changes

ea7346c

handle box in library

1ec8adc

adjust macro to accomodate boxing vtags

f446f2e

fix markdown vtag generation in crm example

2b7ed68

add new goal to crm readme

b4eee87

jstarry reviewed Oct 14, 2019

View reviewed changes

crates/macro/src/html_tree/html_tag/mod.rs Outdated Show resolved Hide resolved

hgzimmerman added 2 commits October 13, 2019 22:36

change macro to use from to convert vtag instead of explicitly boxing

afac09c

bump

6ca17ce

hgzimmerman and others added 16 commits October 14, 2019 19:05

Derive PartialEq for Classes (yewstack#680)

a4f8c5d

bump to stdweb 0.4.19 (yewstack#683)

f531ea4

Use trait objects with explicit dyn in examples (yewstack#687)

5bf8766

Fixes yewstack#685 Address deprecations warnings in the examples directory: warning: trait objects without an explicit `dyn` are deprecated

Fix multi_thread example (yewstack#689)

5112be6

Bump stdweb to 0.4.20 (yewstack#694)

d5c7b83

Bump wasm bindgen to 0.2.50 (yewstack#695)

a44b8e8

* Bump wasm-bindgen to 0.2.50 * Update Cargo.toml * Update Cargo.toml

Variable renames (yewstack#696)

90e4ff0

* childs -> children * precursor -> previous_sibling * cargo fmt and name changes

Fix diff for VText nodes (yewstack#697)

0ecd9f1

Fix VTag attribute updates (yewstack#698)

99dc5ae

Pin ryu dependency to 1.0.0 for emscripten targets (yewstack#703)

f01527a

Stop force installing wasm-bindgen-cli in CI (yewstack#701)

20be32c

Add CI caching for nvm (yewstack#700)

808aebd

Optimize the default change implementation (yewstack#690)

53bbd7e

* Optimize the default `change` implementation Return `false` if `Self::Properties` has a value of `()`. * Use TypeId for checking Properties == ()

Forbid missing Debug implementations (yewstack#673)

e19ec02

* Forbid missing debug implementations * someday I'll remember to run cargo fmt before pushing the first time * add debug for other format types * derive debug for HandlerId

Improve compile error for non-string attributes (yewstack#710)

e6060a5

Fix travis (yewstack#711)

c0a1e30

* Rework travis cache and fix cargo-update * Split examples out of main workspace

jstarry and others added 16 commits October 14, 2019 19:05

Use wasm32-unknown-unknown as the default build target (yewstack#702)

6e35bee

* Use wasm32-unknown-unknown as the default build target * Print rustup installed targets * Add doc_test alias

Use latest chromedriver (yewstack#708)

7e423dc

Enable clippy in CI (yewstack#706)

0f09bdc

* Enable clippy in CI * Fix clippy warnings * Only run fmt and clippy on stable * Fix check script

Cleanup run tests CI script (yewstack#709)

0d29397

Speed up cache (yewstack#707)

7836b58

Remove git files from travis cache

2c5fbb1

Box VComp to reduce size disparity between VNode variants

aea3e15

revert changes

22b049e

handle box in library

576ca2f

adjust macro to accomodate boxing vtags

5781fae

fix markdown vtag generation in crm example

16c3736

add new goal to crm readme

cdad360

change macro to use from to convert vtag instead of explicitly boxing

7b2a1ef

Merge branch 'master' of https://github.com/yewstack/yew into box_vcomp

fd1f0fd

Merge branch 'box_vcomp' of github.com:hgzimmerman/yew into box_vcomp

8ef25d9

remove large_enum_variant allow lint

153e282

jstarry merged commit 5056b84 into yewstack:master Oct 14, 2019

llebout pushed a commit to llebout/yew that referenced this pull request Jan 20, 2020

Box VTag to reduce size disparity between VNode variants (yewstack#675)

3aa6198

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Box VTag to reduce size disparity between VNode variants #675

Box VTag to reduce size disparity between VNode variants #675

hgzimmerman commented Sep 30, 2019

jstarry commented Oct 13, 2019

hgzimmerman commented Oct 13, 2019 •

edited

Loading

jstarry commented Oct 14, 2019

Box VTag to reduce size disparity between VNode variants #675

Box VTag to reduce size disparity between VNode variants #675

Conversation

hgzimmerman commented Sep 30, 2019

jstarry commented Oct 13, 2019

hgzimmerman commented Oct 13, 2019 • edited Loading

jstarry commented Oct 14, 2019

hgzimmerman commented Oct 13, 2019 •

edited

Loading