Early msgs queue for Public worker #596

serzhiio · 2019-08-16T16:54:26Z

Fixes: #637

therustmonk · 2019-08-17T00:25:36Z

Yeah! Looks great now! 👍
Thank you!
Related PR: #595

* Fix typo * Require fmt in travis script * Apply cargo format to all modules

# Conflicts: # src/agent.rs # src/app.rs

* Fix typo * Require fmt in travis script * Apply cargo format to all modules * avoid allocating in diff_classes * avoid allocating for diff_kind * avoid allocating for diff_value * simplify diff_attributes and avoid allocations * return iterator for diff_classes and diff_attributes * rustfmt on vtags * clean apply_diff * more cleaning * apply suggestions * Update proc-macro2, syn and quote to 1.0 CLOSES #590 * Fixed typo * Add support for optional callbacks to component properties * Add tests for a component with optional callback * Fix typo * Add `Classes` to prelude

serzhiio · 2019-08-26T13:04:45Z

any chance to merge?

* Fix typo * Require fmt in travis script * Apply cargo format to all modules * avoid allocating in diff_classes * avoid allocating for diff_kind * avoid allocating for diff_value * simplify diff_attributes and avoid allocations * return iterator for diff_classes and diff_attributes * rustfmt on vtags * clean apply_diff * more cleaning * apply suggestions * Update proc-macro2, syn and quote to 1.0 CLOSES #590 * Fixed typo * Add support for optional callbacks to component properties * Add tests for a component with optional callback * Fix typo * Add `Classes` to prelude

merge

* in yewstack org * Initial implementation using an iterator adaptor to provide a coherent struct to implement Into<VNode> (via From<>) for * update large table example to demonstrate new .html() method instead of 'for' * ran cargo fmt * Add a section for project templates to the README * Change org to YewStack * Implement FromIterator instead of wrapping iterator * remove dead code * ran fmt * Add extend method to Classes * change to union * renamed union back to extend * removed unused import of RangeFull

Merge

update

hgzimmerman · 2019-09-15T00:47:35Z

Can you run cargo fmt?

It seems like the CI is failing on The command "cargo fmt --all -- --check" exited with 1.

jstarry

Hey @serzhiio I took a look too and have some suggestions! Thanks for working on this, super pumped to get this merged 😄

Cargo.toml

src/agent.rs

src/format/bincode.rs

update

serzhiio

In case of workers Id there is a real problem! What if same remote agent created dynamically, what id would it have?

src/agent.rs

src/format/bincode.rs

jstarry · 2019-09-25T15:26:09Z

In case of workers Id there is a real problem! What if same remote agent created dynamically, what id would it have?

If the same remote agent is created, then the REMOTE_AGENTS_POOL will have an Entry::Occupied and so a new will not be created. There will be 2 bridges, and both can send to the msg queue.

serzhiio · 2019-09-25T15:58:52Z

Ok, so could help how could i send isolated commit update with fixes. I'm not a pro with git. ср, 25 сент. 2019 г. в 18:56, Justin Starry <notifications@github.com>:

…

***@***.**** commented on this pull request. ------------------------------ In src/agent.rs <#596 (comment)>: > - } - FromWorker::ProcessOutput(id, output) => { - let callback = slab.borrow().get(id.raw_id()).cloned(); - if let Some(callback) = callback { - callback.emit(output); - } else { - warn!( - "Id of handler for remote worker not exists <slab>: {}", - id.raw_id() - ); + let handler = { + let slab = slab.clone(); + move |data: Vec<u8>, worker: Value| { + let msg = FromWorker::<AGN::Output>::unpack(&data); + match msg { + FromWorker::WorkerLoaded => { I think it is important, because if worker is dropped, and then spawned later, it will seem to already be loaded — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#596?email_source=notifications&email_token=ACPXFN5SGZNGNLY2FY5WUZLQLOCZDA5CNFSM4IMLCS72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCF43CGI#discussion_r328205665>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACPXFN4ALS6VVAF55DEIYWLQLOCZDANCNFSM4IMLCS7Q> .

-- С Уважением, Матыцин Сергей Леонидович sergey.matytsin@gmail.com

jstarry · 2019-09-25T16:00:48Z

@serzhiio you can push a new commit to your master branch :)

jstarry · 2019-09-25T16:06:10Z

@serzhiio I can help you on gitter chat

src/agent.rs

serzhiio · 2019-09-25T18:45:46Z

Isnt TypeId a type unique? What if we have several workers of the same type? It looks that typeid of AGN will be the same for all workers? No? ср, 25 сент. 2019 г., 21:27 Justin Starry <notifications@github.com>:

…

***@***.**** requested changes on this pull request. ------------------------------ In src/agent.rs <#596 (comment)>: > - if let Some(callback) = callback { - callback.emit(output); - } else { - warn!( - "Id of handler for remote worker not exists <slab>: {}", - id.raw_id() - ); + let handler = { + let slab = slab.clone(); + move |data: Vec<u8>, worker: Value| { + let msg = FromWorker::<AGN::Output>::unpack(&data); + match msg { + FromWorker::WorkerLoaded => { + // TODO Send `Connected` message + let _ = REMOTE_AGENTS_LOADED.with(|local| { + local.borrow_mut().insert(AGN::name_of_resource()) Use TypeId::of::<AGN>() instead of AGN::name_of_resource() ------------------------------ In src/agent.rs <#596 (comment)>: > - "Id of handler for remote worker not exists <slab>: {}", - id.raw_id() - ); + let handler = { + let slab = slab.clone(); + move |data: Vec<u8>, worker: Value| { + let msg = FromWorker::<AGN::Output>::unpack(&data); + match msg { + FromWorker::WorkerLoaded => { + // TODO Send `Connected` message + let _ = REMOTE_AGENTS_LOADED.with(|local| { + local.borrow_mut().insert(AGN::name_of_resource()) + }); + REMOTE_AGENTS_EARLY_MSGS_QUEUE.with(|local| { + if let Some(msgs) = + local.borrow_mut().get_mut(AGN::name_of_resource()) Use TypeId::of::<AGN>() instead of AGN::name_of_resource() — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#596?email_source=notifications&email_token=ACPXFN5EGOA3EEQMHSL4ZUDQLOUR3A5CNFSM4IMLCS72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCF5Q35Q#pullrequestreview-293277174>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACPXFN5DK5URFSSGCK5E46LQLOUR3ANCNFSM4IMLCS7Q> .

serzhiio · 2019-09-25T20:15:44Z

Thx for explanations and your time, never used it. Its done, fix pushed. ср, 25 сент. 2019 г. в 21:47, Justin Starry <notifications@github.com>:

…

***@***.**** commented on this pull request. ------------------------------ In src/agent.rs <#596 (comment)>: > - "Id of handler for remote worker not exists <slab>: {}", - id.raw_id() - ); + let handler = { + let slab = slab.clone(); + move |data: Vec<u8>, worker: Value| { + let msg = FromWorker::<AGN::Output>::unpack(&data); + match msg { + FromWorker::WorkerLoaded => { + // TODO Send `Connected` message + let _ = REMOTE_AGENTS_LOADED.with(|local| { + local.borrow_mut().insert(AGN::name_of_resource()) + }); + REMOTE_AGENTS_EARLY_MSGS_QUEUE.with(|local| { + if let Some(msgs) = + local.borrow_mut().get_mut(AGN::name_of_resource()) @serzhiio <https://github.com/serzhiio> the TypeId will be different for each Agent implementor since AGN is generic — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#596?email_source=notifications&email_token=ACPXFN3GOKPYOHXJVKRM3YTQLOW47A5CNFSM4IMLCS72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCF5T4GQ#discussion_r328283777>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACPXFN7KF7TABISGDZ7EXI3QLOW47ANCNFSM4IMLCS7Q> .

-- С Уважением, Матыцин Сергей Леонидович sergey.matytsin@gmail.com

* Implement Debug for ChildRenderer<T> * fix formatter type lifetime * remove fmt * cargo fmt

- cargo fmt - rename DEDICATED_WORKERS_* to REMOTE_AGENTS_* - remove unrelated changes

jstarry

Great work @serzhiio, very happy to have this change merge 👍

jstarry · 2019-09-26T01:39:22Z

bors r+

596: Early msgs queue for Public worker r=jstarry a=serzhiio Fixes: #637 Co-authored-by: serzhiio <sergey.matytsin@gmail.com> Co-authored-by: Justin Starry <justin.starry@icloud.com> Co-authored-by: Henry Zimmerman <hgzimmerman@users.noreply.github.com> Co-authored-by: Terry Raimondo <terry.raimondo@gmail.com> Co-authored-by: Justin Starry <jstarry@users.noreply.github.com>

bors · 2019-09-26T01:48:01Z

Canceled

@jstarry

* Early msgs queue for Public worker * Early msgs queue for Public worker * update (#1) * Fix typo * Require fmt in travis script * Apply cargo format to all modules * ?? * Merge (yewstack#2) * Fix typo * Require fmt in travis script * Apply cargo format to all modules * avoid allocating in diff_classes * avoid allocating for diff_kind * avoid allocating for diff_value * simplify diff_attributes and avoid allocations * return iterator for diff_classes and diff_attributes * rustfmt on vtags * clean apply_diff * more cleaning * apply suggestions * Update proc-macro2, syn and quote to 1.0 CLOSES yewstack#590 * Fixed typo * Add support for optional callbacks to component properties * Add tests for a component with optional callback * Fix typo * Add `Classes` to prelude * binary ser/de issue fix * merge (yewstack#3) * Fix typo * Require fmt in travis script * Apply cargo format to all modules * avoid allocating in diff_classes * avoid allocating for diff_kind * avoid allocating for diff_value * simplify diff_attributes and avoid allocations * return iterator for diff_classes and diff_attributes * rustfmt on vtags * clean apply_diff * more cleaning * apply suggestions * Update proc-macro2, syn and quote to 1.0 CLOSES yewstack#590 * Fixed typo * Add support for optional callbacks to component properties * Add tests for a component with optional callback * Fix typo * Add `Classes` to prelude * added bincode type for data ser de * fixed Into func * Update (yewstack#5) * in yewstack org * Initial implementation using an iterator adaptor to provide a coherent struct to implement Into<VNode> (via From<>) for * update large table example to demonstrate new .html() method instead of 'for' * ran cargo fmt * Add a section for project templates to the README * Change org to YewStack * Implement FromIterator instead of wrapping iterator * remove dead code * ran fmt * Add extend method to Classes * change to union * renamed union back to extend * removed unused import of RangeFull * update * Fix touch events (yewstack#656) * Update changelog for v0.9 release (yewstack#657) * Implement Debug for ChildRenderer<T> (yewstack#655) * Implement Debug for ChildRenderer<T> * fix formatter type lifetime * remove fmt * cargo fmt * Emit initial route to router subscribers (yewstack#634) * Fix typo in RenderService (yewstack#658) * Add From<&String> for Classes implementation * @jstarry feedback - cargo fmt - rename DEDICATED_WORKERS_* to REMOTE_AGENTS_* - remove unrelated changes * TypeId ask key instead &str * Remove .gitignore changes * Update agent.rs * Update agent.rs * Fix merge conflict

Early msgs queue for Public worker

2ddd483

serzhiio added 5 commits August 17, 2019 09:29

Early msgs queue for Public worker

b70987f

update (#1)

7e1a062

* Fix typo * Require fmt in travis script * Apply cargo format to all modules

??

bf7934b

Merge remote-tracking branch 'origin/master'

d87610f

# Conflicts: # src/agent.rs # src/app.rs

serzhiio added 9 commits August 27, 2019 01:44

binary ser/de issue fix

63f4682

added bincode type for data ser de

fe979d0

Merge remote-tracking branch 'origin/master'

79114a9

Merge pull request #4 from yewstack/master

ce2372d

merge

fixed Into func

c22f802

Merge pull request #6 from yewstack/master

334bd8f

Merge

Merge pull request #7 from yewstack/master

d60f425

update

serzhiio mentioned this pull request Sep 14, 2019

Can't send requests to a public agent just after creation #637

Closed

jstarry requested changes Sep 23, 2019

View reviewed changes

Merge pull request #8 from yewstack/master

fae09ae

update

serzhiio commented Sep 23, 2019

View reviewed changes

src/agent.rs Show resolved Hide resolved

src/format/bincode.rs Outdated Show resolved Hide resolved

jstarry mentioned this pull request Sep 25, 2019

Add Dispatchers #639

Merged

jstarry added the feature-request A feature request label Sep 25, 2019

update

8324ca4

jstarry requested changes Sep 25, 2019

View reviewed changes

src/agent.rs Outdated Show resolved Hide resolved

src/agent.rs Outdated Show resolved Hide resolved

jstarry and others added 10 commits September 25, 2019 21:26

Fix touch events (#656)

43d6f73

Update changelog for v0.9 release (#657)

4df0648

Implement Debug for ChildRenderer<T> (#655)

7940645

* Implement Debug for ChildRenderer<T> * fix formatter type lifetime * remove fmt * cargo fmt

Emit initial route to router subscribers (#634)

3e1c364

Fix typo in RenderService (#658)

a79c6b1

Add From<&String> for Classes implementation

3949af1

@jstarry feedback

e477d07

- cargo fmt - rename DEDICATED_WORKERS_* to REMOTE_AGENTS_* - remove unrelated changes

TypeId ask key instead &str

4bccb2f

Remove .gitignore changes

bc8445e

Merge remote-tracking branch 'yew/master' into pr/596

5ab2ae1

jstarry approved these changes Sep 26, 2019

View reviewed changes

Merge branch 'master' into master

9327b1d

jstarry and others added 3 commits September 25, 2019 21:49

Update agent.rs

a3b4c68

Update agent.rs

d1210ae

Fix merge conflict

27b20f9

jstarry merged commit dfc4968 into yewstack:master Sep 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Early msgs queue for Public worker #596

Early msgs queue for Public worker #596

serzhiio commented Aug 16, 2019 •

edited by jstarry

Loading

therustmonk commented Aug 17, 2019

serzhiio commented Aug 26, 2019

hgzimmerman commented Sep 15, 2019

jstarry left a comment

serzhiio left a comment

jstarry commented Sep 25, 2019

serzhiio commented Sep 25, 2019 via email

jstarry commented Sep 25, 2019

jstarry commented Sep 25, 2019

serzhiio commented Sep 25, 2019 via email

serzhiio commented Sep 25, 2019 via email

jstarry left a comment

jstarry commented Sep 26, 2019

bors bot commented Sep 26, 2019

Early msgs queue for Public worker #596

Early msgs queue for Public worker #596

Conversation

serzhiio commented Aug 16, 2019 • edited by jstarry Loading

therustmonk commented Aug 17, 2019

serzhiio commented Aug 26, 2019

hgzimmerman commented Sep 15, 2019

jstarry left a comment

Choose a reason for hiding this comment

serzhiio left a comment

Choose a reason for hiding this comment

jstarry commented Sep 25, 2019

serzhiio commented Sep 25, 2019 via email

jstarry commented Sep 25, 2019

jstarry commented Sep 25, 2019

serzhiio commented Sep 25, 2019 via email

serzhiio commented Sep 25, 2019 via email

jstarry left a comment

Choose a reason for hiding this comment

jstarry commented Sep 26, 2019

bors bot commented Sep 26, 2019

Canceled

serzhiio commented Aug 16, 2019 •

edited by jstarry

Loading