Add own Classes struct implementation #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide details of Classes set implementation and add a feature to produce that struct from variety of sources like `&str`, `String` and `Vec<T> where T: AsRef<str>`.
jstarry
approved these changes
Aug 12, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 13, 2019
585: Add own Classes struct implementation r=DenisKolodin a=DenisKolodin Hide details of Classes set implementation and add a feature to produce that struct from variety of sources like `&str`, `String` and `Vec<T> where T: AsRef<str>`. I need this to have an effective way to construct complex classes set for https://github.com/yewstack/facade. With this PR we can do something like: ```rust let mut classes = vec!["container"]; classes.push("fluid"); // or let mut classes = Classes::new(); classes.append("container"); if fluid_flag { container.append("fluid"); } html! { <div classes=classes /> } ``` In the future we can implement `impl Info<Classes> for (tuple)` and simplify macro by delegating **tuples to classes** conversion to type system (instead of macro). Let's give a chance to CI to check it 🤞 Also I applied `cargo fmt` to the root crate sources. Co-authored-by: Denis Kolodin <deniskolodin@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide details of Classes set implementation and add a feature to produce that struct from variety of sources like
&str,StringandVec<T> where T: AsRef<str>.I need this to have an effective way to construct complex classes set for https://github.com/yewstack/facade. With this PR we can do something like:
In the future we can implement
impl Info<Classes> for (tuple)and simplify macro by delegating tuples to classes conversion to type system (instead of macro).Let's give a chance to CI to check it 🤞
Also I applied
cargo fmtto the root crate sources.