Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the routing example #385

Merged
merged 3 commits into from
Sep 4, 2018
Merged

fix the routing example #385

merged 3 commits into from
Sep 4, 2018

Conversation

stephanbuys
Copy link
Contributor

The links need to be mutable.

@@ -2,3 +2,5 @@ target
**/*.rs.bk
Cargo.lock
orig.*
/.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .gitignore niceties may be out of scope for this PR, although I would appreciate them myself and I think a separate PR would be welcome.

Thank you for keeping the routing example in line with the rest of the project.

@therustmonk
Copy link
Member

@stephanbuys Thank you for the PR 🎉
@hgzimmerman Thank you for the review 👍

I've separated changes of .gitignore.
Also I added the routing example to the showcase. I accidentally missed it 😕

@stephanbuys
Copy link
Contributor Author

My pleasure 👍Glad to assist

@therustmonk
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Sep 4, 2018
385: fix the routing example r=DenisKolodin a=stephanbuys

The links need to be mutable.

Co-authored-by: Stephan Buys <hello@stephanbuys.com>
Co-authored-by: Denis Kolodin <deniskolodin@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 4, 2018

Build succeeded

@bors bors bot merged commit 1662970 into yewstack:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants