-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webkitdirectory to the boolean attributes list #3214
Add webkitdirectory to the boolean attributes list #3214
Conversation
Visit the preview URL for this PR (updated for commit 9290673): https://yew-rs-api--pr3214-bool-into-prop-value-gcv6mn98.web.app (expires Tue, 11 Apr 2023 19:54:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
✅ None of the examples has changed their size significantly. |
Benchmark - SSRYew Master
Pull Request
|
I think we need to set / unset this attribute if its value is set to boolean or delegate this attribute to property. Boolean attributes dictates whether it is truthy or falsy by its presence. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes#boolean_attributes In addition, implicit string conversion feels like too JavaScript-ish to me. This is usually discouraged in Rust. |
This reverts commit 8468e7a.
If I understood correctly The spec also mentions that webkitdirectory is not yet standardized, ctlf+f |
Description
Fixes #2968
Checklist