Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #3171

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Update dependencies #3171

merged 4 commits into from
Mar 28, 2023

Conversation

ranile
Copy link
Member

@ranile ranile commented Mar 19, 2023

Description

  • Update yew-macro and yew-router-macro to use the newly released syn v2

Checklist

  • I have reviewed my own code
  • I have added tests

github-actions[bot]
github-actions bot previously approved these changes Mar 19, 2023
@ranile ranile added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Mar 19, 2023
@github-actions
Copy link

github-actions bot commented Mar 19, 2023

Visit the preview URL for this PR (updated for commit e9da7cf):

https://yew-rs-api--pr3171-syn-2-cpze1ofl.web.app

(expires Mon, 03 Apr 2023 15:29:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Mar 19, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 99.081 99.102 +0.021 +0.021%
boids 169.249 169.263 +0.014 +0.008%
communication_child_to_parent 90.012 90.012 0 0.000%
communication_grandchild_with_grandparent 103.549 103.547 -0.002 -0.002%
communication_grandparent_to_grandchild 99.569 99.565 -0.004 -0.004%
communication_parent_to_child 87.264 87.263 -0.001 -0.001%
contexts 105.854 105.851 -0.003 -0.003%
counter 85.229 85.230 +0.001 +0.001%
counter_functional 85.414 85.413 -0.001 -0.001%
dyn_create_destroy_apps 88.012 88.032 +0.021 +0.023%
file_upload 99.314 99.314 0 0.000%
function_memory_game 162.304 162.328 +0.024 +0.015%
function_router 335.514 335.480 -0.033 -0.010%
function_todomvc 157.921 157.927 +0.006 +0.004%
futures 222.993 222.992 -0.001 -0.000%
game_of_life 105.891 105.915 +0.024 +0.023%
immutable 179.303 179.307 +0.004 +0.002%
inner_html 81.640 81.641 +0.001 +0.001%
js_callback 110.185 110.183 -0.002 -0.002%
keyed_list 197.180 197.179 -0.001 -0.000%
mount_point 84.809 84.809 0 0.000%
nested_list 111.349 111.348 -0.001 -0.001%
node_refs 92.479 92.481 +0.002 +0.002%
password_strength 1534.787 1539.784 +4.997 +0.326%
portals 95.625 95.627 +0.002 +0.002%
router 307.044 307.015 -0.029 -0.010%
simple_ssr 140.469 140.469 0 0.000%
ssr_router 372.244 372.230 -0.014 -0.004%
suspense 107.376 107.438 +0.062 +0.057%
timer 88.108 88.139 +0.030 +0.034%
todomvc 140.028 140.026 -0.002 -0.001%
two_apps 85.832 85.833 +0.001 +0.001%
web_worker_fib 149.964 149.957 -0.007 -0.005%
webgl 84.349 84.375 +0.026 +0.031%

✅ None of the examples has changed their size significantly.

github-actions[bot]
github-actions bot previously approved these changes Mar 19, 2023
@github-actions
Copy link

github-actions bot commented Mar 19, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 371.593 371.953 371.783 0.137
Hello World 10 660.607 682.701 667.122 6.482
Function Router 10 2294.447 2344.026 2312.991 14.216
Concurrent Task 10 1006.654 1008.423 1007.597 0.453

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 376.734 392.404 378.481 4.895
Hello World 10 663.907 667.648 665.198 1.176
Function Router 10 2278.498 2305.713 2289.707 9.660
Concurrent Task 10 1006.933 1008.558 1007.717 0.397

github-actions[bot]
github-actions bot previously approved these changes Mar 19, 2023
packages/yew-macro/Cargo.toml Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously approved these changes Mar 27, 2023
Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading to syn 2 seems like a good idea, now that all dependencies have moved as well! Ty for championing the migration.

Cargo.toml Outdated Show resolved Hide resolved
packages/yew-macro/tests/hook_attr/hook_macro-fail.stderr Outdated Show resolved Hide resolved
@ranile ranile requested review from WorldSEnder, Jaffa-Cakes and futursolo and removed request for Jaffa-Cakes March 27, 2023 15:31
@ranile ranile added A-yew-router-macro Area: The yew-router-macro crate A-yew-macro Area: The yew-macro crate labels Mar 27, 2023
@futursolo futursolo merged commit cc9dd02 into master Mar 28, 2023
@ranile ranile deleted the syn-2 branch August 26, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-macro Area: The yew-macro crate A-yew-router-macro Area: The yew-router-macro crate dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants