-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add use_bridge docs #2722
add use_bridge docs #2722
Conversation
Visit the preview URL for this PR (updated for commit ecf61b5): https://yew-rs-api--pr2722-spanishpear-use-brid-vrp7wa5n.web.app (expires Thu, 30 Jun 2022 04:52:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
✅ None of the examples has changed their size significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading the live preview, I have one more suggestion
Not sure why the integration tests are failing here |
Because time v0.3.10 bumped the MSRV to 1.57, which means the tests - running on 1.56.1 - fail. Not to worry about for this PR, a fix should be imminent, and it's unrelated. |
@futursolo is this still accurate after |
It will need some minor updates, but I don't think the Worker v2 will forfeit the example. I have Agent v2 in progress and very close to finish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because of #2722 (comment)
@WorldSEnder can you also update your review?
Description
Adds an example to
use_bridge
Fixes #2325
I wrote this up rather quickly in my lunch break so it may not be entirely correct but a good place to start :)
Checklist