Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add use_bridge docs #2722

Merged

Conversation

SpanishPear
Copy link
Contributor

Description

Adds an example to use_bridge

Fixes #2325

I wrote this up rather quickly in my lunch break so it may not be entirely correct but a good place to start :)

Checklist

  • I have reviewed my own code
  • I have added tests

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Visit the preview URL for this PR (updated for commit ecf61b5):

https://yew-rs-api--pr2722-spanishpear-use-brid-vrp7wa5n.web.app

(expires Thu, 30 Jun 2022 04:52:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
boids 172.593 172.593 0 0.000%
contexts 109.615 109.615 0 0.000%
counter 86.550 86.550 0 0.000%
counter_functional 87.203 87.203 0 0.000%
dyn_create_destroy_apps 89.691 89.691 0 0.000%
file_upload 102.625 102.625 0 0.000%
function_memory_game 166.887 166.887 0 0.000%
function_router 351.597 351.597 0 0.000%
function_todomvc 161.557 161.557 0 0.000%
futures 226.279 226.279 0 0.000%
game_of_life 107.188 107.188 0 0.000%
inner_html 83.617 83.617 0 0.000%
js_callback 112.853 112.853 0 0.000%
keyed_list 195.107 195.107 0 0.000%
mount_point 86.180 86.180 0 0.000%
nested_list 115.688 115.688 0 0.000%
node_refs 93.597 93.597 0 0.000%
password_strength 1538.653 1538.653 0 0.000%
portals 97.219 97.219 0 0.000%
router 320.381 320.381 0 0.000%
simple_ssr 154.493 154.493 0 0.000%
ssr_router 397.850 397.850 0 0.000%
suspense 110.540 110.540 0 0.000%
timer 89.260 89.260 0 0.000%
todomvc 142.614 142.614 0 0.000%
two_apps 87.159 87.159 0 0.000%
web_worker_fib 153.414 153.414 0 0.000%
webgl 87.438 87.438 0 0.000%

✅ None of the examples has changed their size significantly.

@WorldSEnder WorldSEnder added A-yew-agent Area: The yew-agent crate S-waiting-on-author Status: awaiting action from the author of the issue/PR labels Jun 11, 2022
Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the live preview, I have one more suggestion

@SpanishPear
Copy link
Contributor Author

Not sure why the integration tests are failing here

@WorldSEnder
Copy link
Member

WorldSEnder commented Jun 23, 2022

Because time v0.3.10 bumped the MSRV to 1.57, which means the tests - running on 1.56.1 - fail. Not to worry about for this PR, a fix should be imminent, and it's unrelated.

@ranile
Copy link
Member

ranile commented Jun 24, 2022

@futursolo is this still accurate after gloo-worker 0.2? The hook implementation still needs to be updated.

@futursolo
Copy link
Member

@futursolo is this still accurate after gloo-worker 0.2? The hook implementation still needs to be updated.

It will need some minor updates, but I don't think the Worker v2 will forfeit the example.

I have Agent v2 in progress and very close to finish.
I think it might be fine to merge this pull request and I will adjust the example when landing Agent v2.

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because of #2722 (comment)

@WorldSEnder can you also update your review?

@WorldSEnder WorldSEnder merged commit f82af86 into yewstack:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-agent Area: The yew-agent crate S-waiting-on-author Status: awaiting action from the author of the issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use_bridge has no example on website, or in the examples folder
4 participants