Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defaulted type parameter. #2284

Merged
merged 2 commits into from
Dec 19, 2021
Merged

Fix defaulted type parameter. #2284

merged 2 commits into from
Dec 19, 2021

Conversation

futursolo
Copy link
Member

Description

Fixes #2283

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@voidpumpkin voidpumpkin added the A-yew-macro Area: The yew-macro crate label Dec 19, 2021
voidpumpkin
voidpumpkin approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ranile
ranile approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ranile ranile merged commit 5b0bbd5 into yewstack:master Dec 19, 2021
@futursolo futursolo deleted the fix-default-type-param branch January 27, 2022 14:00
da-x pushed a commit to da-x/yew that referenced this pull request Jul 27, 2022
@futursolo @da-x
Fix defaulted type parameter. (yewstack#2284)
03e785e 
* Fix defaulted type parameter.

* Add test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranile ranile ranile approved these changes

@voidpumpkin voidpumpkin voidpumpkin approved these changes

Assignees
No one assigned
Labels
A-yew-macro Area: The yew-macro crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function Component loses defaulted type parameter
3 participants
@futursolo @voidpumpkin @ranile