Refactor use ref hooks #2093
Merged
Refactor use ref hooks #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`use_ref` has been renamed to `use_mut_ref` and `use_ref` has become a similar hook for immutable reference. This is different from React but I think lines up nicely with Rust as a reference is immutable unless specified to be a mut ref.
|
Visit the preview URL for this PR (updated for commit 8b64369): https://yew-rs--pr2093-use-ref-6ujaz3md.web.app (expires Sun, 28 Nov 2021 12:57:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
I'm going to take over this PR. Hopefully we can land it quickly for 0.19 |
ranile
previously approved these changes
Nov 21, 2021
|
@hamza1311 btw if you want this merged you can just approve, since this PR is not yours :D |
|
I would approve but it is my PR 🙃 |
I will approve it instead |
ranile
approved these changes
Nov 21, 2021
Madoshakalaka
pushed a commit
to Madoshakalaka/yew
that referenced
this pull request
Nov 23, 2021
* Refactor use ref hooks `use_ref` has been renamed to `use_mut_ref` and `use_ref` has become a similar hook for immutable reference. This is different from React but I think lines up nicely with Rust as a reference is immutable unless specified to be a mut ref. * fix CI Co-authored-by: Hamza <muhammadhamza1311@gmail.com> (cherry picked from commit 071f1b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_refhas been renamed touse_mut_refanduse_refhas become asimilar hook for immutable reference.
This is different from React but I think lines up nicely with Rust as a
reference is immutable unless specified to be a mut ref.
This PR also adds
use_node_refwhich is a specialised version ofuse_reffor
NodeRef- it is more ergonomic to have this separate hook and it avoidsthe need of wrapping an
Rcvalue in anotherRc.Description
Fixes #1642
Checklist
cargo make pr-flow