Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2064

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Update dependencies #2064

merged 1 commit into from
Sep 19, 2021

Conversation

mc1098
Copy link
Contributor

@mc1098 mc1098 commented Sep 19, 2021

Description

General review of dependencies, removing ones that are not used and
bumping up minor versions only to avoid breakage.

Consistent use of version so that we use the most recent minor/patch
version of a dependency when building Yew crates.

There were quite a few dependencies in the yew crate that aren't used, I'm guessing from
moving yew_agent module to yew-agent crate and from the removal of the services.

Removed from the yew crate:

  • agent feature
  • anymap - yew_agent module
  • http - services
  • serde - services & yew_agent module
  • serde_json - services
  • thiserror - services?
  • bincode - yew_agent module
  • base64 - services?
  • rmp-serde - services
  • rustversion - ?
  • serde_derive - services?
  • trybuild - ?
  • Quite a few features removed from web_sys which were required
    for services & yew_agent module.

Removed from the yew-router-macro:

  • heck

After #2057 I did also review all the licences for the dependencies, most
of which have a "MIT or Apache-2.0" with some just having a "MIT"
only licence. So shouldn't have any more surprises on that front :)

Fixes #0000
Part of #2052

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
    I have added tests N/A

Outstanding issues

General review of dependencies, removing ones that are not used and
bumping up minor versions to avoid breakage.

Consistent use of caret so that we use the most recent minor/patch
version of a dependency when building Yew crates.
@siku2 siku2 merged commit adb3fcf into yewstack:master Sep 19, 2021
@mc1098 mc1098 deleted the dep-review branch September 19, 2021 09:18
@voidpumpkin voidpumpkin added A-yew Area: The main yew crate A-yew-agent Area: The yew-agent crate A-yew-router Area: The yew-router crate labels Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate A-yew-agent Area: The yew-agent crate A-yew-router Area: The yew-router crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants