Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy lints from 1.54.0 #1976

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Conversation

Xavientois
Copy link
Contributor

Description

Rust 1.54.0 introduced a number of new clippy lints. This PR updates the code to respond to those lints

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code

Copy link
Contributor

@mc1098 mc1098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me 🎉

UpdatePost(PostId, String),
RemovePost(PostId),
pub enum PostRequest {
Create(String),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes clippy::enum_variant_names

@@ -61,7 +61,7 @@ where
T: for<'de> Deserialize<'de>,
{
let query = yew::utils::document().location().unwrap().search().unwrap();
serde_urlencoded::from_str(query.strip_prefix("?").unwrap_or(""))
serde_urlencoded::from_str(query.strip_prefix('?').unwrap_or(""))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes clippy::single_char_pattern

@siku2 siku2 merged commit c9deba0 into yewstack:master Jul 30, 2021
@voidpumpkin voidpumpkin added A-yew-agent Area: The yew-agent crate A-yew-macro Area: The yew-macro crate A-yew-router Area: The yew-router crate labels Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-agent Area: The yew-agent crate A-yew-macro Area: The yew-macro crate A-yew-router Area: The yew-router crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants