Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize vtag construction #1867

Merged
merged 3 commits into from
May 23, 2021
Merged

Optimize vtag construction #1867

merged 3 commits into from
May 23, 2021

Conversation

bakape
Copy link
Contributor

@bakape bakape commented May 23, 2021

Description

Reduced needless copying and reallocations in VTag construction from the html! macro.

Benchmark results using https://github.com/bakape/js-framework-benchmark
Screenshot_20210523_195218

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@siku2 siku2 merged commit 7cac4d4 into yewstack:master May 23, 2021
@bakape bakape mentioned this pull request Jul 8, 2021
Merged
3 tasks
@voidpumpkin voidpumpkin added A-yew Area: The main yew crate A-yew-macro Area: The yew-macro crate labels Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-yew Area: The main yew crate A-yew-macro Area: The yew-macro crate performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bakape @siku2 @voidpumpkin