Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary allocation from AnyScope #1830

Merged
merged 1 commit into from
May 2, 2021

Conversation

Diggsey
Copy link
Contributor

@Diggsey Diggsey commented May 2, 2021

Description

Rc<dyn Any> can be directly downcasted into an Rc<T> so there is no need to add a new layer of Rc.

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@siku2 siku2 merged commit c7bc8e0 into yewstack:master May 2, 2021
@siku2
Copy link
Member

siku2 commented May 2, 2021

Thanks!

@Diggsey Diggsey deleted the anyscope-improvement branch May 2, 2021 15:44
@voidpumpkin voidpumpkin added the A-yew Area: The main yew crate label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants