Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out stdweb #1697

Merged
merged 4 commits into from
Jan 23, 2021
Merged

Conversation

philip-peterson
Copy link
Contributor

@philip-peterson philip-peterson commented Jan 13, 2021

Description

Per #1569, v0.18 will be the last release beholden to stdweb. As a result, and also because it makes SSR work easier, this PR removes support to stdweb.

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@philip-peterson
Copy link
Contributor Author

philip-peterson commented Jan 13, 2021

This PR should include all the code changes now. Documentation will require a second pass (I'd propose for us to put that in another PR).

@github-actions
Copy link

github-actions bot commented Jan 13, 2021

Visit the preview URL for this PR (updated for commit ac253c1):

https://yew-rs--pr1697-peterson-rip-out-std-uxpfudx9.web.app

(expires Sat, 30 Jan 2021 16:11:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@jstarry jstarry force-pushed the peterson/rip-out-stdweb branch 2 times, most recently from 64403c1 to fef1fa3 Compare January 23, 2021 15:00
@jstarry jstarry merged commit 5fc4387 into yewstack:master Jan 23, 2021
@jstarry
Copy link
Member

jstarry commented Jan 23, 2021

Bye bye stdweb 👋🏻

@voidpumpkin voidpumpkin added A-yew Area: The main yew crate A-yew-macro Area: The yew-macro crate labels Nov 26, 2021
@izissise
Copy link
Contributor

You will be missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate A-yew-macro Area: The yew-macro crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants