Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export KilledByThreadManager exception #1016

Closed
wants to merge 1 commit into from

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Dec 4, 2024

No description provided.

so that it can be caught, if necessary
@edsko
Copy link
Contributor Author

edsko commented Dec 4, 2024

I think CI failures must be unrelated to this PR, since I literally just added an export.

@Vlix
Copy link
Contributor

Vlix commented Dec 4, 2024

Yes, the time-manager was bumped to 2.0, and http2, the dependency of warp, uses it but that version hasn't been added to the stack.yml files used for the tests.
If you could add http2-5.3.9 to the extra-deps of all the stack*.ymls (except stack-nightly.yml), that'd be great 😅

@kazu-yamamoto
Copy link
Contributor

@edsko Would you tell me why this exception should be exported? It is used only internally...

@Vlix I noticed this failure of CI and am trying to fix it. The fix should be done independent on this PR. So, @edsko does not have to tackle the CI issue.

@kazu-yamamoto
Copy link
Contributor

CI has been fixed.

@edsko
Copy link
Contributor Author

edsko commented Dec 5, 2024

Would you tell me why this exception should be exported? It is used only internally...

Because it is critical that I am able to catch it.

@edsko
Copy link
Contributor Author

edsko commented Dec 5, 2024

Would you tell me why this exception should be exported? It is used only internally...

Specifically, in the http2 case, this exception is thrown to server handlers, which are running user-defined code (my code), and http2 sometimes kills those handlers when it considers them no longer required (when a client disappears), but I need to allow them to continue to run and finish what they were doing, so instead I catch the exception, mark the client as having disappeared in case the handler still tries to communicate, but allow the handler to continue to run to completion.

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Dec 6, 2024
@kazu-yamamoto
Copy link
Contributor

OK!
Rebased and merged.
Also, a new version has been released.

@edsko edsko deleted the edsko/export-exception branch December 17, 2024 13:09
@edsko
Copy link
Contributor Author

edsko commented Dec 17, 2024

Thanks @kazu-yamamoto !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants