Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to ESM #862

Merged
merged 7 commits into from
Apr 6, 2025
Merged

Convert to ESM #862

merged 7 commits into from
Apr 6, 2025

Conversation

mshima
Copy link
Member

@mshima mshima commented Apr 4, 2025

Closes #787

Based on #859

  • Fix 787 - Switch from CJS to ESM

  • switch project to type=module

  • adopt import/export syntax throughout codebase

  • update meow (ESM support since v10)

  • remove global-tunnel-ng branch since we're > Node 10

  • replace proxyquire (no ESM) with testdouble

  • replace nyc (no ESM) with c8

  • shim __dirname

  • remove unused --no-update-notifier in CLI

  • [WIP] disable failing tabtab test

  • Make sure we're resetting td mocks

Purpose of this pull request?

  • Documentation update
  • Bug fix
  • Enhancement
  • Other, please explain:

What changes did you make?

Is there anything you'd like reviewers to focus on?

tjlahr and others added 2 commits April 4, 2025 14:48
* Fix 787 - Switch from CJS to ESM

* switch project to type=module
* adopt import/export syntax throughout codebase
* update meow (ESM support since v10)
* remove global-tunnel-ng branch since we're > Node 10
* replace proxyquire (no ESM) with testdouble
* replace nyc (no ESM) with c8
* shim __dirname
* remove unused --no-update-notifier in CLI
* [WIP] disable failing tabtab test

* Make sure we're resetting td mocks
Copy link

socket-security bot commented Apr 4, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/node@22.10.222.14.0 None 0 2.33 MB types
npm/c8@10.1.3 Transitive: environment, filesystem, shell +37 2.85 MB
npm/meow@5.0.013.2.0 None 0 419 kB sindresorhus
npm/parse-help@1.0.0 None +4 14.3 kB sindresorhus

🚮 Removed packages: npm/global-tunnel-ng@2.7.1, npm/nyc@17.1.0

View full report↗︎

@mshima mshima changed the title Switch from CJS to ESM (#859) Convert to ESM Apr 4, 2025
@mshima mshima marked this pull request as ready for review April 5, 2025 01:47
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is big change! Thanks for making it possible ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from CJS (CommonJS) to ESM (ECMAScript Modules)
3 participants