Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken wiring helpers. #373

Merged
merged 2 commits into from
Oct 16, 2013
Merged

Fixing broken wiring helpers. #373

merged 2 commits into from
Oct 16, 2013

Conversation

timrwood
Copy link
Contributor

As noted in #174, the arguments are reversed for wiring.appendToFile and wiring.prependToFile.

As noted in #174, the arguments are reversed for `wiring.appendToFile` and `wiring.prependToFile`.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4717c0d on timrwood:patch-1 into 73c1881 on yeoman:master.

@passy
Copy link
Member

passy commented Oct 15, 2013

Could you perhaps add a unit test so we can track regressions in the future?

@SBoudrias
Copy link
Member

Could you perhaps add a unit test so we can track regressions in the future?

+1

Looks good otherwise. Its a shame no one tackled it before

@addyosmani
Copy link
Member

LGTM too minus the missing test.

@timrwood
Copy link
Contributor Author

I added some tests for wiring.append, wiring.prepend, and wiring.domUpdate while I was at it.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 65e145a on timrwood:patch-1 into 73c1881 on yeoman:master.

@SBoudrias
Copy link
Member

Awesome! Thanks a lot!

SBoudrias added a commit that referenced this pull request Oct 16, 2013
Fixing broken wiring helpers.
@SBoudrias SBoudrias merged commit f11c1d8 into yeoman:master Oct 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants