This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
Replace RequireJS with Almond during build [fixes #296] #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marian-r
force-pushed
the
requirejs-build-fix
branch
from
e59886b to
2cacbea
Compare
| @@ -107,5 +107,8 @@ <h3 class="text-muted"><%= appName %></h3> | |||
| r.parentNode.insertBefore(e,r)}(window,document,'script','ga')); | |||
| ga('create','UA-XXXXX-X');ga('send','pageview'); | |||
| </script> | |||
| <% if (includeRequireJS) { -%> | |||
| <script data-main="scripts/main" src="bower_components/requirejs/require.js"></script> | |||
| <% } -%> | |||
There was a problem hiding this comment.
simple and clever solution to bypass the usemin block generated by htmlWiring.appendScript 👍 nice job!
There was a problem hiding this comment.
Thanks :) I saw that append was producing incorrect indentation, so I fixed it with this simple solution.
|
👍 LGTM thank you very much @marian-r for the awesome work putting this all together happy to see the requirejs build finally working again 🎊 |
ruyadorno
added a commit
that referenced
this pull request
Nov 22, 2015
Replace RequireJS with Almond during build [fixes #296]
ruyadorno
added a commit
to ruyadorno/generator-backbone
that referenced
this pull request
Nov 22, 2015
|
Thanks for your patience 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #299 & #300.
Generated output in some configurations can be seen here: https://github.com/marian-r/generator-backbone-examples.