Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bin-version-check package (#53) #54

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

Logicer16
Copy link
Contributor

Reviving pr #53 after being open for over a year with no activity since, and then (presumably) closed due to inactivity.

The original issue (#49) along with the pr stated that:

Installing software using the latest version of yeoman-doctor gives deprecation warnings:

npm WARN deprecated cross-spawn-async@2.2.5: cross-spawn no longer requires a build toolchain, use it instead

The package was updated in an upstream dependency, execa, which eventually was updated in bin-version-check version 4.0.0:

Right before the pr became inactive the @LitoMore had approved the pr and pinged @SBoudrias (presumably to merge the pr).

@Logicer16
Copy link
Contributor Author

CI said it failed with:

Error: Command failed: yo --version
/home/travis/.nvm/versions/node/v8.17.0/lib/node_modules/yo/node_modules/yeoman-environment/lib/environment.js:534
      } catch {
              ^

SyntaxError: Unexpected token {

I don't know whether this is a problem that will stop merging and if it's a problem with my branch or not.

@LitoMore
Copy link
Contributor

LitoMore commented Jun 3, 2021

That because yeoman/doctor is using Node.js 8 testing. We could upgrade the version list to [12, 14, 16] and target our engine to "node": ">=12".

@Logicer16
Copy link
Contributor Author

Would upgrading cause any issues? I don't have enough experience with Node.js and npm to be confident I won't break anything.

I don't think I did anything different from #53, and seen as that passed its checks, what changed?

@LitoMore
Copy link
Contributor

LitoMore commented Jun 3, 2021

I don't think I did anything different from #53, and seen as that passed its checks, what changed?

yeoman-environment version changed.

@mshima mshima closed this Jun 3, 2021
@mshima mshima reopened this Jun 3, 2021
@mshima mshima merged commit 820860a into yeoman:main Jun 3, 2021
@mshima
Copy link
Member

mshima commented Jun 3, 2021

@LitoMore would be nice to drop workaround for node < 10 compatibility e009e3d

@LitoMore
Copy link
Contributor

LitoMore commented Jun 3, 2021

@mshima Sure. I can help.

@LitoMore LitoMore mentioned this pull request Jun 3, 2021
@Logicer16 Logicer16 deleted the update-bin-version-check branch June 3, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants