Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New fields: Spot Savings, Spot Reclaim Rate #9

Closed
wants to merge 3 commits into from

Conversation

Pluies
Copy link
Contributor

@Pluies Pluies commented Jul 10, 2020

Hi again @v9n πŸ˜„

This time it's for new functionality: get the savings & reclaim rate for spot instances!

A bit of background – I wanted a way to compare spot prices vs. their reclaim rate. The data is available in various places, but never side-by-side (ugh), so I decided to patch it all up together here.

I'm not sure this is something you'd like to incorporate in ec2.shop itself, as it may start to make things a bit cramped, but I thought I'd send a PR anyway if this is of interest πŸ‘

Here's a screenshot of the feature in action:
Screenshot 2020-07-10 at 12 14 50

@yeo yeo deleted a comment from brava-vinh Jul 17, 2020
@yeo yeo deleted a comment from ciphervinh Jul 17, 2020
@v9n
Copy link
Member

v9n commented Jul 17, 2020

@Pluies

This is great.

This add more feature so give me sometime to review and test it. But definetely useful to have. That's the whole purpose of this UI, right? To save us time going to the crunchy AWS pricing page :-).

I think I'm going to merge this in. But are you able to add a checkbox that say sth like this

  • Show Spot Saving

And we hide those saving columns by default. Because I plan to add reserver pice and this is getting croweded πŸ—‘οΈ

@Pluies
Copy link
Contributor Author

Pluies commented Jul 24, 2020

@v9n all done! New checkbox "Show Spot data", that toggles whether to show just the basic info or basic info + Spot price / Spot savings / Spot reclaim rate πŸ‘

I'm not a huge fan of the implementation I've written, as it duplicates the window._pricedata array, but I'm not sure of a better way to go there 🀷

@v9n
Copy link
Member

v9n commented Jun 27, 2024

Hi @Pluies After so many years and more use on Spot I think this is useful. I will rebase and getting this to our release.

@v9n
Copy link
Member

v9n commented Jun 30, 2024

Hi @Pluies This is implemented. Thank you so much for your initial PR.

@v9n v9n closed this Jun 30, 2024
@v9n
Copy link
Member

v9n commented Jun 30, 2024

@Pluies Because I don't use this PR directly I add a credit section on the REDME:https://github.com/yeo/ec2.shop?tab=readme-ov-file#spot-saving-and-spot-reclaim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants