Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency rubocop-rspec to v3 #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 11, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop-rspec (changelog) '2.31.0' -> '3.4.0' age adoption passing confidence

Release Notes

rubocop/rubocop-rspec (rubocop-rspec)

v3.4.0

Compare Source

  • Fix RSpec/SortMetadata cop to limit sorting to trailing metadata arguments. ([@​cbliard])
  • Replace RSpec/StringAsInstanceDoubleConstant with RSpec/VerifiedDoubleReference configured to only support constant class references. ([@​corsonknowles])
  • Fix RSpec/EmptyExampleGroup cop false positive when a simple conditional is used inside an iterator. ([@​lovro-bikic])

v3.3.0

Compare Source

  • Deprecate top_level_group? method from TopLevelGroup mixin as all of its callers were intentionally removed from Rubocop/RSpec. ([@​corsonknowles])
  • Fix false positive for RSpec/EmptyMetadata for splat kwargs. ([@​pirj])

v3.2.0

Compare Source

  • Fix RSpec/VoidExpect to only operate inside an example block. ([@​corsonknowles])
  • Change RSpec/ContextWording cop to always report an offense when both Prefixes and AllowedPatterns are empty. ([@​ydah])
  • Add support for and and or compound matchers to RSpec/ChangeByZero cop. ([@​ydah])

v3.1.0

Compare Source

  • Add RSpec/StringAsInstanceDoubleConstant to check for and correct strings used as instance_doubles. ([@​corsonknowles])
  • Fix false-positive for RSpec/UnspecifiedException when a method is literally named raise_exception. ([@​aarestad])
  • Fix false-positive for RSpec/UnspecifiedException when not_to raise_error is used within a block. ([@​aarestad], [@​G-Rath])

v3.0.5

Compare Source

  • Fix false-negative and error for RSpec/MetadataStyle when non-literal args are used in metadata in EnforceStyle: hash. ([@​cbliard])
  • Improve offense message for RSpec/IndexedLet. ([@​earlopain])

v3.0.4

Compare Source

  • Fix false-negative for UnspecifiedException when matcher is chained. ([@​r7kamura])

v3.0.3

Compare Source

  • Add support for Unicode RIGHT SINGLE QUOTATION MARK in RSpec/ExampleWording. ([@​jdufresne])
  • Suppress deprecation warning for RSpec/MultipleExpectations, RSpec/MultipleMemoizedHelpers, and RSpec/NestedGroups cops. ([@​koic])

v3.0.2

Compare Source

  • Fix wrong autocorrect for RSpec/ScatteredSetup when hook contains heredoc. ([@​earlopain])
  • Fix false negative for RSpec/PredicateMatcher when expectation contains custom failure message. ([@​earlopain])
  • Facilitate the 3.0 upgrade flow with proper extracted cop messages. ([@​jeppester])

v3.0.1

Compare Source

  • Bump RuboCop requirement to +1.61. ([@​ydah])

v3.0.0

Compare Source

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. ([@​ydah])
  • Remove RuboCop::RSpec::Language::NodePattern. ([@​ydah])
  • Remove RSpec/FilePath cop. ([@​ydah])
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. ([@​ydah])
  • Add new RSpec/MissingExpectationTargetMethod cop. ([@​krororo])
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. ([@​earlopain])

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version\_3.html


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 377fc0f to 0c7e771 Compare June 11, 2024 16:02
@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 0c7e771 to 7c46ec7 Compare July 3, 2024 10:37
@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 7c46ec7 to 776738a Compare July 12, 2024 09:58
@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 776738a to 173161c Compare August 5, 2024 16:57
@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 173161c to b4c0bb2 Compare September 7, 2024 14:10
@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from b4c0bb2 to 899bacc Compare October 1, 2024 15:29
@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 899bacc to fbd45a5 Compare October 26, 2024 11:00
@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from fbd45a5 to 9def9a7 Compare December 12, 2024 17:37
@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 9def9a7 to 6c1187e Compare January 20, 2025 14:56
Copy link
Contributor Author

renovate bot commented Jan 29, 2025

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Gemfile.lock
Fetching gem metadata from https://rubygems.org/........
Resolving dependencies...

Could not find compatible versions

Because rubocop-rspec >= 3.0.1 depends on rubocop ~> 1.61
  and Gemfile depends on rubocop = 1.52.1,
  rubocop-rspec >= 3.0.1 cannot be used.
So, because Gemfile depends on rubocop-rspec = 3.4.0,
  version solving has failed.

@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 6c1187e to e0283bb Compare January 29, 2025 19:43
@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from e0283bb to 1f5d6da Compare February 5, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants