Resumes

[g4s8]

zerocracy/farm#800 - resumes schema, tests, xsl

[0crat]

Job #334 is now in scope, role is REV

[0crat]

This pull request #334 is assigned to @carlosmiranda/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

[carlosmiranda]

@g4s8 one comment

[carlosmiranda]

@g4s8 since we're enforcing uniqueness of the login attribute, let's make the rest of data different.

[g4s8]

@carlosmiranda fixed in f921594, please look again

[carlosmiranda]

@yegor256 good to merge

[0crat]

@carlosmiranda/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[carlosmiranda]

@yegor256 ping, good to merge this now

[yegor256]

@rultor merge

[rultor]

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

[0crat]

@ypshenychka/z please review this job completed by @carlosmiranda/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #334 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @yegor256/z

[ypshenychka]

@carlosmiranda According to our QA Rules:

The code reviewer found at least three problems in the code.
Comments were mostly about design problems, not cosmetic issues.

Only one issue was found during code review.
Please confirm that you'll try to find at least three problems while future reviews.

[carlosmiranda]

@ypshenychka confirmed

[ypshenychka]

@carlosmiranda Thanks.

[ypshenychka]

@0crat quality acceptable

[0crat]

Order was finished, quality is "acceptable": +15 point(s) just awarded to @carlosmiranda/z

[0crat]

Quality review completed: +8 point(s) just awarded to @ypshenychka/z