#862 Enforce immutability of IterableEnvelope through its iterator #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job #890 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #890 +/- ##
============================================
+ Coverage 87.09% 87.09% +<.01%
Complexity 1457 1457
============================================
Files 259 259
Lines 3773 3774 +1
Branches 212 212
============================================
+ Hits 3286 3287 +1
Misses 439 439
Partials 48 48
Continue to review full report at Codecov.
|
Isammoc
changed the title
llorllale
reviewed
May 28, 2018
| /** | ||
| * Test case for {@link IterableEnvelope}. | ||
| * | ||
| * @since 0.34 |
There was a problem hiding this comment.
@Isammoc we're on 0.35 now
|
@Isammoc just one minor comment, see above |
|
@llorllale Done |
|
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
@llorllale Done! FYI, the full log is here (took me 9min) |
|
The job #890 is now out of scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for #862