#839: Introduce IteratorOfBytes and IteratorOfDoubles

[proshin-roman]

PR for #839.

• added IteratorOfBytes and IteratorOfDoubles
• added tests for new classes
• refactored implementation of IterableOfBytes and IterableOfDoubles so that they use new classes
• refactored IterableOfFloats and IterableOfInts: got rid of redundant UncheckedScalar wrapping

[0crat]

Job #863 is now in scope, role is REV

[codecov-io]

Codecov Report

Merging #863 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #863      +/-   ##
============================================
+ Coverage     85.83%   85.86%   +0.03%     
- Complexity     1405     1411       +6     
============================================
  Files           253      255       +2     
  Lines          3706     3714       +8     
  Branches        209      207       -2     
============================================
+ Hits           3181     3189       +8     
  Misses          477      477              
  Partials         48       48

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/org/cactoos/iterable/IterableOfBytes.java	100% <100%> (ø)	1 <1> (-2)	⬇️
...n/java/org/cactoos/iterable/IterableOfDoubles.java	100% <100%> (ø)	1 <1> (-2)	⬇️
...ain/java/org/cactoos/iterator/IteratorOfBytes.java	100% <100%> (ø)	5 <5> (?)
...n/java/org/cactoos/iterator/IteratorOfDoubles.java	100% <100%> (ø)	5 <5> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c8372...01ff587. Read the comment docs.

[0crat]

This pull request #863 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

[paulodamaso]

@proshin-roman Just correct a couple of typos, please.

[paulodamaso]

@proshin-roman Please correct this typo.

[paulodamaso]

@proshin-roman Please correct this typo.

[proshin-roman]

@paulodamaso I've fixed all comments - please review the pull request again

[paulodamaso]

@proshin-roman Good to go, thanks.

[paulodamaso]

@rultor good to merge

[rultor]

@rultor good to merge

@paulodamaso Thanks for your request. @llorllale Please confirm this.

[llorllale]

@rultor merge

[rultor]

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@llorllale Done! FYI, the full log is here (took me 12min)

[0crat]

@elenavolokhova/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #863 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

[elenavolokhova]

@paulodamaso According to our Policy:

The code reviewer found at least three problems in the code (discuss);
Comments were mostly about design problems, not cosmetic issues;

Please, confirm that you will try to find at least 3 not cosmetic issues next time.

[paulodamaso]

@elenavolokhova confirm

[elenavolokhova]

@0crat quality acceptable

[elenavolokhova]

@0crat status

[0crat]

@0crat status (here)

@elenavolokhova This is what I know about this job, as in §32:

• The job #863 is not in scope
• Job footprint (restricted area)