#720: Add more tests for TeeInput class.

[proshin-roman]

Pull request for #720: adds more unit tests for TeeInput class. But still, not all ctors are covered by tests as it would require more time and would produce a huge - non-reviewable - pull request.

[0crat]

Job #732 is now in scope, role is REV

[0crat]

This pull request #732 is assigned to @neonailol/z, here is why. The budget is 15 minutes, see §4. Please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket. If you decide that this PR should not be accepted ever, also inform the architect.

[codecov-io]

Codecov Report

Merging #732 into master will increase coverage by 4.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #732      +/-   ##
============================================
+ Coverage     78.82%   82.92%   +4.09%     
- Complexity     1180     1249      +69     
============================================
  Files           223      223              
  Lines          3367     3367              
  Branches        191      191              
============================================
+ Hits           2654     2792     +138     
+ Misses          666      528     -138     
  Partials         47       47

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/io/TeeInput.java	97.29% <ø> (+81.08%)	71 <0> (+60)	⬆️
src/main/java/org/cactoos/io/BytesOf.java	94.2% <0%> (+2.89%)	29% <0%> (+1%)	⬆️
src/main/java/org/cactoos/io/InputOf.java	90% <0%> (+3.33%)	29% <0%> (+1%)	⬆️
...main/java/org/cactoos/io/WriterAsOutputStream.java	84% <0%> (+4%)	11% <0%> (+1%)	⬆️
src/main/java/org/cactoos/io/ReaderAsBytes.java	100% <0%> (+8.33%)	8% <0%> (+1%)	⬆️
src/main/java/org/cactoos/io/WriterTo.java	82.6% <0%> (+8.69%)	9% <0%> (+1%)	⬆️
src/main/java/org/cactoos/io/OutputTo.java	88.57% <0%> (+22.85%)	15% <0%> (+4%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f3b7f...a8dbb9b. Read the comment docs.

[proshin-roman]

@neonailol ping

[neonailol]

All tests contain multiple assertions, please correct it according to http://www.yegor256.com/2017/05/17/single-statement-unit-tests.html

[proshin-roman]

@neonailol Thanks for your comment! I will fix it as soon as pull request #731 is merged (then I will be able to use just a single assert that will check both results).

[0crat]

@neonailol/z this job was assigned to you 8 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[0crat]

The user @neonailol/z resigned from #732, please stop working. Reason for job resignation: It is older than 10 days, see §8

[0crat]

Resigned on delay, see §8: -15 points just awarded to @neonailol/z

[0crat]

This pull request #732 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

[proshin-roman]

@neonailol I've refactored all tests using a new TeeInputHasResultMatcher (that was introduced in #721). Please review the pull request again. Thanks!

[neonailol]

@proshin-roman thanks, I will review it soon

Sent from my ZenFone 2 Laser (ZE601KL) using FastHub

[neonailol]

@rultor good to merge

[proshin-roman]

@yegor256 something went wrong with this issue (0crat doesn't respond). Could you try to merge the pull request, please?

[proshin-roman]

@yegor256 merge the pull request please

[yegor256]

@rultor merge

[rultor]

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

[0crat]

@elenavolokhova/z please review this job completed by @fabriciofx/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #732 is now out of scope

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 points just awarded to @yegor256/z

[elenavolokhova]

@0crat status

[0crat]

@0crat status (here)

@elenavolokhova This is what I know about this job, as in §32:

• The job #732 is not in scope
• The job is waiting quality review verdict by @elenavolokhova/z for 1days
• @fabriciofx/z will receive 15 minutes after quality review
• Job footprint (restricted area)

[elenavolokhova]

@0crat quality bad as far as @neonailol was reassigned from this PR and @fabriciofx didn't reviewed it actually

[0crat]

Quality is low, no payment, see §31

[0crat]

Quality review completed: +8 point(s) just awarded to @elenavolokhova/z