Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

172: Max and Min #263

Merged
merged 6 commits into from
Jun 29, 2017
Merged

172: Max and Min #263

merged 6 commits into from
Jun 29, 2017

Conversation

fabriciofx
Copy link
Contributor

@fabriciofx fabriciofx commented Jun 28, 2017

As per #172:

  • Max introduced.
  • Min introduced.

@fabriciofx fabriciofx mentioned this pull request Jun 28, 2017
@fabriciofx
Copy link
Contributor Author

@svendiedrichsen Thanks for your report. I think fixed them now. Could you check it?

@codecov-io
Copy link

Codecov Report

Merging #263 into master will increase coverage by 0.48%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
+ Coverage      73.5%   73.98%   +0.48%     
- Complexity      387      398      +11     
============================================
  Files           124      126       +2     
  Lines          1200     1230      +30     
  Branches         41       47       +6     
============================================
+ Hits            882      910      +28     
- Misses          297      298       +1     
- Partials         21       22       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/list/Min.java 100% <100%> (ø) 6 <6> (?)
src/main/java/org/cactoos/list/Max.java 86.66% <86.66%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a598e...8485e7c. Read the comment docs.

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 29, 2017

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8485e7c into yegor256:master Jun 29, 2017
@rultor
Copy link
Collaborator

rultor commented Jun 29, 2017

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

@fabriciofx fabriciofx mentioned this pull request Jun 29, 2017
@svendiedrichsen
Copy link
Contributor

svendiedrichsen commented Jun 29, 2017

Tests are looking good. I was just thinking if the original NoSuchElementException isn't already good enough. @fabriciofx: WDYT?

@fabriciofx
Copy link
Contributor Author

@svendiedrichsen Makes sense. I'll do it. Thanks!

@fabriciofx fabriciofx deleted the 172 branch June 29, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants