For #1462: Introduce text.Mapped #1485

andreoss · 2020-10-16T14:36:44Z

Per #1462

Add text.Mapped
Use it where applicable

victornoel · 2020-10-17T08:29:32Z

@0crat status

0crat · 2020-10-17T09:01:33Z

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

The job #1485 is in scope for 18hr
The role is REV
The job is assigned to @fabriciofx /z for 17hr
There is no monetary reward attached, it's a free job
The job doesn't have any impediments
The budget is 15 minutes/points
These users are banned and won't be assigned:
- @andreoss /z: This user reported the ticket
Job footprint (restricted area)

andreoss · 2020-10-21T19:49:33Z

@fabriciofx Please take a look

fabriciofx

@andreoss Please, take a look in my comments.

src/test/java/org/cactoos/text/MappedTest.java

fabriciofx · 2020-10-30T17:03:42Z

src/test/java/org/cactoos/text/MappedTest.java

+ *
+ * @since 0.47
+ */
+final class MappedTest {


@andreoss please, add a #equals() test.

@fabriciofx Why do you think Mapped should preserve equality?

@andreoss Some code like it new Mapped(String::toLowercase, new TextOf("ABC").equals("abc") is valid? If yes, then Mapped should preserve equality, right?

@fabriciofx In order to do that, it has to extend TextEnvelope and use TextOf. Both seem to be unnecessary for this task.

@andreoss Ok, thanks for this information!

@andreoss @fabriciofx actually all texts implementation should either implement equals themselves or indeed delegate to an implementation of text that does. So I think we need to do it either way here yes. Same with tostring and hashcode. You can add a todo if you want.

@victornoel Done. It uses TextOf now.

src/test/java/org/cactoos/text/MappedTest.java

codecov-io · 2020-10-30T20:29:57Z

Codecov Report

Merging #1485 (92ce712) into master (deec154) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1485      +/-   ##
============================================
+ Coverage     89.40%   89.44%   +0.04%     
- Complexity     1632     1639       +7     
============================================
  Files           278      281       +3     
  Lines          3906     3914       +8     
  Branches        210      208       -2     
============================================
+ Hits           3492     3501       +9     
+ Misses          382      381       -1     
  Partials         32       32

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/text/Strict.java	`100.00% <ø> (ø)`	`4.00 <0.00> (ø)`
src/main/java/org/cactoos/text/Sub.java	`89.47% <ø> (-0.53%)`	`8.00 <0.00> (ø)`
src/main/java/org/cactoos/text/SwappedCase.java	`100.00% <ø> (ø)`	`5.00 <0.00> (ø)`
src/main/java/org/cactoos/text/TrimmedRight.java	`100.00% <ø> (ø)`	`4.00 <0.00> (ø)`
src/main/java/org/cactoos/text/Lowered.java	`100.00% <100.00%> (ø)`	`3.00 <1.00> (ø)`
src/main/java/org/cactoos/text/Mapped.java	`100.00% <100.00%> (ø)`	`1.00 <1.00> (?)`
src/main/java/org/cactoos/text/Replaced.java	`100.00% <100.00%> (ø)`	`4.00 <0.00> (ø)`
src/main/java/org/cactoos/text/Reversed.java	`100.00% <100.00%> (ø)`	`2.00 <1.00> (ø)`
src/main/java/org/cactoos/text/Trimmed.java	`100.00% <100.00%> (ø)`	`1.00 <1.00> (ø)`
src/main/java/org/cactoos/text/TrimmedLeft.java	`100.00% <100.00%> (ø)`	`4.00 <0.00> (ø)`
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deec154...92ce712. Read the comment docs.

victornoel · 2020-11-03T10:29:21Z

@0crat status

0crat · 2020-11-03T10:31:53Z

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

The job #1485 is in scope for 18days
The role is REV
The job is assigned to @fabriciofx /z for 18days
There is no monetary reward attached, it's a free job
The job doesn't have any impediments
The budget is 15 minutes/points
These users are banned and won't be assigned:
- @andreoss /z: This user reported the ticket
Job footprint (restricted area)

fabriciofx

@andreoss It seems fine to me. @victornoel WDYT? Can you merge it?

fabriciofx · 2020-11-06T19:14:49Z

src/test/java/org/cactoos/text/MappedTest.java

+ *
+ * @since 0.47
+ */
+final class MappedTest {


@andreoss Ok, thanks for this information!

victornoel

@andreoss see the one comment

andreoss · 2020-11-11T09:29:16Z

@victornoel equals/hashCode are provided by TextOf now. Please, take a look

victornoel · 2020-11-14T17:34:17Z

@andreoss great!

victornoel · 2020-11-14T17:34:23Z

@rultor merge

rultor · 2020-11-14T17:34:59Z

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2020-11-14T17:47:01Z

@rultor merge

@victornoel Done! FYI, the full log is here (took me 12min)

0crat · 2020-12-24T00:58:43Z

@fabriciofx /z resigned from #1485, since the job is not in scope anymore

andreoss added 12 commits October 16, 2020 17:32

(yegor256#1462) Add text.Mapped

57f058b

(yegor256#1462) Use text.Mapped

9e931a2

(yegor256#1462) Use text.Mapped

6615a28

(yegor256#1462) Use text.Mapped

8996680

(yegor256#1462) Use text.Mapped

d6513dd

(yegor256#1462) Use text.Mapped

3b6ddce

(yegor256#1462) Use text.Mapped

a0e1eb9

(yegor256#1462) Use text.Mapped

f7cbbd6

(yegor256#1462) Use text.Mapped

637ecf4

(yegor256#1462) Use text.Mapped

a5ebafd

(yegor256#1462) Use text.Mapped

3707553

(yegor256#1462) Remove todo

9b69568

0crat added 0crat/scope 0crat/role/REV labels Oct 16, 2020

fabriciofx suggested changes Oct 30, 2020

View reviewed changes

andreoss added 2 commits October 30, 2020 23:23

(yegor256#1462) Fix typo

7da56b0

(yegor256#1462) Use TextIs' over TextHasString'

62669b5

(yegor256#1462) Remove unused import

397ac51

andreoss mentioned this pull request Nov 6, 2020

TextIs should test asString(), toString(), equals() and hashCode() llorllale/cactoos-matchers#199

Open

fabriciofx approved these changes Nov 6, 2020

View reviewed changes

victornoel requested changes Nov 7, 2020

View reviewed changes

andreoss requested a review from victornoel November 8, 2020 22:35

(yegor256#1462) Use TextOf' in order to provide equals' & `hashCode'

92ce712

andreoss force-pushed the issue-1462 branch from 9aa332c to 92ce712 Compare November 8, 2020 22:41

rultor merged commit b838438 into yegor256:master Nov 14, 2020

0crat removed the 0crat/scope label Dec 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For #1462: Introduce text.Mapped #1485

For #1462: Introduce text.Mapped #1485

andreoss commented Oct 16, 2020

victornoel commented Oct 17, 2020

0crat commented Oct 17, 2020

andreoss commented Oct 21, 2020

fabriciofx left a comment

fabriciofx Oct 30, 2020

andreoss Oct 30, 2020

fabriciofx Oct 31, 2020 •

edited

Loading

andreoss Nov 6, 2020

fabriciofx Nov 6, 2020

victornoel Nov 7, 2020 •

edited

Loading

andreoss Nov 8, 2020

codecov-io commented Oct 30, 2020 •

edited

Loading

victornoel commented Nov 3, 2020

0crat commented Nov 3, 2020

fabriciofx left a comment

fabriciofx Nov 6, 2020

victornoel left a comment

andreoss commented Nov 11, 2020

victornoel commented Nov 14, 2020

victornoel commented Nov 14, 2020

rultor commented Nov 14, 2020

rultor commented Nov 14, 2020

0crat commented Dec 24, 2020

For #1462: Introduce text.Mapped #1485

For #1462: Introduce text.Mapped #1485

Conversation

andreoss commented Oct 16, 2020

victornoel commented Oct 17, 2020

0crat commented Oct 17, 2020

andreoss commented Oct 21, 2020

fabriciofx left a comment

Choose a reason for hiding this comment

fabriciofx Oct 30, 2020

Choose a reason for hiding this comment

andreoss Oct 30, 2020

Choose a reason for hiding this comment

fabriciofx Oct 31, 2020 • edited Loading

Choose a reason for hiding this comment

andreoss Nov 6, 2020

Choose a reason for hiding this comment

fabriciofx Nov 6, 2020

Choose a reason for hiding this comment

victornoel Nov 7, 2020 • edited Loading

Choose a reason for hiding this comment

andreoss Nov 8, 2020

Choose a reason for hiding this comment

codecov-io commented Oct 30, 2020 • edited Loading

Codecov Report

victornoel commented Nov 3, 2020

0crat commented Nov 3, 2020

fabriciofx left a comment

Choose a reason for hiding this comment

fabriciofx Nov 6, 2020

Choose a reason for hiding this comment

victornoel left a comment

Choose a reason for hiding this comment

andreoss commented Nov 11, 2020

victornoel commented Nov 14, 2020

victornoel commented Nov 14, 2020

rultor commented Nov 14, 2020

rultor commented Nov 14, 2020

0crat commented Dec 24, 2020

fabriciofx Oct 31, 2020 •

edited

Loading

victornoel Nov 7, 2020 •

edited

Loading

codecov-io commented Oct 30, 2020 •

edited

Loading