-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1119) Remove static matchers from list #1158
(#1119) Remove static matchers from list #1158
Conversation
Job #1158 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
=========================================
Coverage 89.15% 89.15%
Complexity 1575 1575
=========================================
Files 271 271
Lines 3890 3890
Branches 215 215
=========================================
Hits 3468 3468
Misses 371 371
Partials 51 51 Continue to review full report at Codecov.
|
This pull request #1158 is assigned to @vzurauskas/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
@vzurauskas ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale Only syntax changes, nothing to comment on. Can be merged.
@llorllale ping |
@llorllale can we merge this? |
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
@llorllale Done! FYI, the full log is here (took me 13min) |
There is an unrecoverable failure on my side. Please, submit it here:
0.48.2: CID: cad528ba-d245-424f-a2d7-311b1a17aa00, Type: "Close job" |
There is an unrecoverable failure on my side. Please, submit it here:
0.48.2: CID: cad528ba-d245-424f-a2d7-311b1a17aa00, Type: "Close job" |
@0crat out |
Code review was too long (16 days), architects (@llorllale) were penalized, see §55 |
@sereshqua/z please review this job completed by @vzurauskas/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@vzurauskas Job #1158 is not in the agenda of @vzurauskas/z, can't inspect |
@vzurauskas The job #1158 is now out of scope |
Payment to |
@0crat quality bad |
Quality is low, no payment, see §31 |
Quality review completed: +4 point(s) just awarded to @sereshqua/z |
This is for #1119. I haven't add the list package to the includes of the plugin because there is is still the
MatcherAssert
static to be migrated toAssertion
.