Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1119) Remove static matchers from list #1158

Merged
merged 1 commit into from
Jul 20, 2019

Conversation

victornoel
Copy link
Collaborator

This is for #1119. I haven't add the list package to the includes of the plugin because there is is still the MatcherAssert static to be migrated to Assertion.

@0crat
Copy link
Collaborator

0crat commented Jul 6, 2019

Job #1158 is now in scope, role is REV

@codecov-io
Copy link

codecov-io commented Jul 6, 2019

Codecov Report

Merging #1158 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1158   +/-   ##
=========================================
  Coverage     89.15%   89.15%           
  Complexity     1575     1575           
=========================================
  Files           271      271           
  Lines          3890     3890           
  Branches        215      215           
=========================================
  Hits           3468     3468           
  Misses          371      371           
  Partials         51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7590f7...498d1dd. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Jul 6, 2019

This pull request #1158 is assigned to @vzurauskas/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator Author

@vzurauskas ping :)

Copy link
Contributor

@vzurauskas vzurauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale Only syntax changes, nothing to comment on. Can be merged.

@victornoel
Copy link
Collaborator Author

@llorllale ping

@victornoel
Copy link
Collaborator Author

@llorllale can we merge this?

@llorllale
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 20, 2019

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 498d1dd into yegor256:master Jul 20, 2019
@rultor
Copy link
Collaborator

rultor commented Jul 20, 2019

@rultor merge

@llorllale Done! FYI, the full log is here (took me 13min)

@0crat
Copy link
Collaborator

0crat commented Jul 21, 2019

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@dddff4c1-9156-49e2-a2d9-cf978c5a9655, thread: pool-11-thread-8
com.zerocracy.farm.sync.SyncProject[76] java.lang.IllegalStateException: Failed to acquire "wbs.xml" in "C63314D6Z" in 2min: java.util.concurrent.locks.ReentrantLock@6d09edc9[Locked by thread pool-470-thread-1]

0.48.2: CID: cad528ba-d245-424f-a2d7-311b1a17aa00, Type: "Close job"

@0crat
Copy link
Collaborator

0crat commented Jul 21, 2019

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@dddff4c1-9156-49e2-a2d9-cf978c5a9655, thread: pool-11-thread-8
com.zerocracy.farm.sync.SyncProject[76] java.lang.IllegalStateException: Failed to acquire "orders.xml" in "C63314D6Z" in 2min: java.util.concurrent.locks.ReentrantLock@6d09edc9[Locked by thread pool-470-thread-1]

0.48.2: CID: cad528ba-d245-424f-a2d7-311b1a17aa00, Type: "Close job"

@victornoel victornoel deleted the 1119-no-more-static-matchers branch July 21, 2019 08:18
@vzurauskas
Copy link
Contributor

@0crat out

@0crat
Copy link
Collaborator

0crat commented Jul 22, 2019

Code review was too long (16 days), architects (@llorllale) were penalized, see §55

@0crat
Copy link
Collaborator

0crat commented Jul 22, 2019

@sereshqua/z please review this job completed by @vzurauskas/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jul 22, 2019
@0crat
Copy link
Collaborator

0crat commented Jul 22, 2019

@0crat out (here)

@vzurauskas Job #1158 is not in the agenda of @vzurauskas/z, can't inspect

@0crat
Copy link
Collaborator

0crat commented Jul 22, 2019

@0crat out (here)

@vzurauskas The job #1158 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jul 22, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

@sereshqua
Copy link

@0crat quality bad

@0crat
Copy link
Collaborator

0crat commented Jul 23, 2019

Quality is low, no payment, see §31

@0crat
Copy link
Collaborator

0crat commented Jul 23, 2019

Quality review completed: +4 point(s) just awarded to @sereshqua/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants