(#904) CollectionEnvelope.equals compare objects of Collection interface #1057
Conversation
|
Job #1057 is now in scope, role is |
|
This pull request #1057 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
| @@ -144,6 +147,18 @@ public void differentHashCode() { | |||
| ); | |||
| } | |||
|
|
|||
| @Test | |||
| public void collectionEnvelopeShouldBeEqualToCollection() { | |||
There was a problem hiding this comment.
@scratchboom Please, test if an empty CollectionEnvelope and an empty Collection are equals.
`Assertion.affirm()` call added. Test `emptyCollectionEnvelopeShouldBeEqualToEmptyCollection` added.
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
===========================================
+ Coverage 87.47% 87.57% +0.1%
- Complexity 1515 1519 +4
===========================================
Files 265 267 +2
Lines 3887 3895 +8
Branches 212 215 +3
===========================================
+ Hits 3400 3411 +11
+ Misses 438 435 -3
Partials 49 49
Continue to review full report at Codecov.
|
|
@fabriciofx ping |
|
@0crat refuse |
|
@llorllale The user @fabriciofx/z resigned from #1057, please stop working. Reason for job resignation: Order was cancelled |
|
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
|
This pull request #1057 is assigned to @iprogrammerr/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
@llorllale Done! FYI, the full log is here (took me 14min) |
|
@rultor release, tag is |
@llorllale OK, I will release it now. Please check the progress here |
|
Quality is low, no payment, see §31: |
|
Job was finished in 0 hours, bonus for fast delivery is possible (see §36) |
|
The job #1057 is now out of scope |
|
Payment to |
@llorllale Done! FYI, the full log is here (took me 14min) |
No description provided.