Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed calls to size() and cache from IterableAsList #105

Merged
merged 3 commits into from
Jun 12, 2017

Conversation

Timmeey
Copy link
Contributor

@Timmeey Timmeey commented Jun 10, 2017

No more calls to size() if not needed.

Modifications in the underlying Iterable would lead to inconsistent cache. Removed cache completely.
Caches do not work for modifyable Iterables.

…move not working cache

no more calls to size() if not needed. Modifications in the underlying Iterable would lead to inconsistent cache. Removed cache completely.
Caches do not work for modifyable Iterables.
@0crat
Copy link
Collaborator

0crat commented Jun 10, 2017

@Timmeey I'm not managing this repo, remove the webhook or contact me in Slack //cc @yegor256

Since size() is not called all the time, and the premise is a mutable iterable, the size() can not be cached.
@Timmeey
Copy link
Contributor Author

Timmeey commented Jun 10, 2017

@yegor256 am i right in assuming that this IterableAsList should reflect changes in the underlying Iterable?

@yegor256
Copy link
Owner

@rultor try to merge

@rultor
Copy link
Collaborator

rultor commented Jun 11, 2017

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jun 11, 2017

@rultor try to merge

@Timmeey @yegor256 Oops, I failed. You can see the full log here (spent 24s)

+ image=yegor256/java8
+ directory=
+ squash=false
+ ff=default
+ rebase=false
+ container=yegor256_cactoos_105
+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:yegor256/cactoos.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''JAVA_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''fork=git@github.com:Timmeey/cactoos.git'\''' ';' 'export '\''fork_branch=ListOfIterableNotUseSize'\''' ';' 'export '\''head=git@github.com:yegor256/cactoos.git'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_id=105'\''' ';' 'export '\''pull_title=Removed calls to size() and cache from IterableAsList'\''' ';' 'sudo gem install --no-rdoc --no-ri pdd' ';' 'mvn clean install -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean site -Psite --errors --settings ../settings.xml' ';' 'mvn clean' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';'
+ rm -rf .gpg
+ cd repo
+ git remote add fork git@github.com:Timmeey/cactoos.git
+ git remote update
Fetching origin
Fetching fork
From github.com:Timmeey/cactoos
 * [new branch]      #101FuncAsIterator -> fork/#101FuncAsIterator
 * [new branch]      ListOfIterableNotUseSize -> fork/ListOfIterableNotUseSize
 * [new branch]      TestForFilteredIteratorRemoveMethod -> fork/TestForFilteredIteratorRemoveMethod
 * [new branch]      gh-pages   -> fork/gh-pages
 * [new branch]      master     -> fork/master
+ args=
+ '[' default == default ']'
+ args=' --ff'
+ '[' default == no ']'
+ '[' default == only ']'
+ export BRANCH=__rultor
+ BRANCH=__rultor
++ git show-branch __rultor
++ wc -l
+ '[' 0 -gt 0 ']'
+ git checkout -B __rultor fork/ListOfIterableNotUseSize
Switched to a new branch '__rultor'
Branch __rultor set up to track remote branch ListOfIterableNotUseSize from fork.
+ git checkout -B master origin/master
Switched to and reset branch 'master'
Branch master set up to track remote branch master from origin.
Your branch is up-to-date with 'origin/master'.
+ '[' false == true ']'
+ '[' false == true ']'
+ git merge --ff __rultor
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
Automatic merge failed; fix conflicts and then commit the result.
'cid' file is absent, container wasn't started correctly

@yegor256
Copy link
Owner

@rultor try to merge

@rultor
Copy link
Collaborator

rultor commented Jun 12, 2017

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit f0eb57b into yegor256:master Jun 12, 2017
@rultor
Copy link
Collaborator

rultor commented Jun 12, 2017

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 10min)

@Timmeey Timmeey mentioned this pull request Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants