Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangeOf is not final #746

Closed
vssekorin opened this issue Mar 22, 2018 · 3 comments
Closed

RangeOf is not final #746

vssekorin opened this issue Mar 22, 2018 · 3 comments

Comments

@vssekorin
Copy link
Contributor

org.cactoos.iterable.RangeOf is not final. If I'm not mistaken, all classes should be final or abstract, except decarating envelopes. But because of Decorating Envelopes, mvn clean install -Pqulice is unable to warn this (no methods - no warning).
@0crat
Copy link
Collaborator

0crat commented Mar 22, 2018

@yegor256/z please, pay attention to this issue

yegor256 added a commit that referenced this issue Mar 23, 2018
@yegor256
#746 RangeOf is final
7177dd4
@yegor256
Copy link
Owner

@vssekorin fixed in 7177dd4 thanks!

@0crat
Copy link
Collaborator

0crat commented Mar 23, 2018

The job is not in WBS, won't close the order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yegor256 @vssekorin @0crat