Skip to content

Commit

Permalink
Merge branch '__rultor'
Browse files Browse the repository at this point in the history
  • Loading branch information
rultor committed Feb 6, 2020
2 parents c941b2d + ab1380f commit d756bdd
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/test/java/org/cactoos/collection/JoinedTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
*/
package org.cactoos.collection;

import java.util.Collections;
import org.cactoos.iterable.IterableOf;
import org.cactoos.list.ListOf;
import org.hamcrest.collection.IsCollectionWithSize;
Expand All @@ -40,9 +39,6 @@
* @checkstyle JavadocMethodCheck (500 lines)
* @checkstyle MagicNumber (500 line)
* @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
* @todo #898:15min Replace Collections.emptyList() with the {@link ListOf}
* That is because it is necessary to get rid of the static methods
* as much as possible
*/
@SuppressWarnings("PMD.TooManyMethods")
public final class JoinedTest {
Expand Down Expand Up @@ -78,7 +74,7 @@ public void sizeEmptyReturnZero() {
new Assertion<>(
"Size must be 0",
new Joined<String>(
Collections.emptyList()
new ListOf<String>()
),
new IsCollectionWithSize<>(new IsEqual<>(0))
).affirm();
Expand All @@ -101,7 +97,7 @@ public void withoutItemsIsEmpty() {
new Assertion<>(
"Must be empty",
new Joined<String>(
Collections.emptyList()
new ListOf<String>()
),
new IsEmptyCollection<>()
).affirm();
Expand Down

1 comment on commit d756bdd

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on d756bdd Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 898-4936d4fd disappeared from src/test/java/org/cactoos/collection/JoinedTest.java, that's why I closed #1218. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

Please sign in to comment.