removed constants

yegor256 · Mar 30, 2018 · c1ccfb4 · c1ccfb4
1 parent 80346f9
commit c1ccfb4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 15 deletions.
diff --git a/src/main/java/org/cactoos/scalar/InheritanceLevel.java b/src/main/java/org/cactoos/scalar/InheritanceLevel.java
@@ -39,7 +39,7 @@
  *   2 -> two inheritance levels. (ex. matching FileNotFoundException with
  *        Exception)
  *   ...
- *   999 -> classes are not related.
+ *   Integer.MAX_VALUE -> classes are not related.
  *      (ex. matching FileNotFoundException with RuntimeException)
  *  </p>
  *
@@ -49,16 +49,6 @@
  */
 public final class InheritanceLevel implements Scalar<Integer> {
 
-    /**
-     * Classes are identical.
-     */
-    private static final int IDENTICAL = 0;
-
-    /**
-     * Classes are not related.
-     */
-    private static final int NOT_RELATED = 999;
-
     /**
      * Base class.
      */
@@ -83,7 +73,7 @@ public InheritanceLevel(final Class<?> cderived, final Class<?> cbase) {
     public Integer value() {
         final int level;
         if (this.base.equals(this.derived)) {
-            level = InheritanceLevel.IDENTICAL;
+            level = 0;
         } else {
             level = this.calculateLevel();
         }
@@ -95,7 +85,7 @@ public Integer value() {
      * @return Integer Level
      */
     private int calculateLevel() {
-        int level = InheritanceLevel.NOT_RELATED;
+        int level = Integer.MAX_VALUE;
         Class<?> sclass = this.derived.getSuperclass();
         int idx = 0;
         while (!sclass.equals(Object.class)) {

diff --git a/src/test/java/org/cactoos/scalar/InheritanceLevelTest.java b/src/test/java/org/cactoos/scalar/InheritanceLevelTest.java
@@ -51,12 +51,11 @@ public void twoInheritanceLevelsBetweenClasses() {
 
     @Test
     public void classesAreNotRelated() {
-        final int expected = 999;
         MatcherAssert.assertThat(
             new InheritanceLevel(
                 FileNotFoundException.class, RuntimeException.class
             ).value(),
-            Matchers.equalTo(expected)
+            Matchers.equalTo(Integer.MAX_VALUE)
         );
     }