-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency sinatra to v4 #543
Conversation
⚠ Artifact update problemRenovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
The artifact failure details are included below: File name: Gemfile.lock
|
b557859
to
fd413f0
Compare
@pnatashap maybe you can help upgrade sinatra to v4? |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
OK, failed tests, will check it |
all is good if switch ruby version to 3+ and it looks like it is due to Faraday https://github.com/lostisland/faraday?tab=readme-ov-file#supported-ruby-versions but I see that octokit is tested on 2.7 version, so may be there is a workaround. Will investigate it |
@pnatashap one of my products runs on Sinatra 4, maybe it will help: https://github.com/yegor256/netbout |
That one is also on Ruby 3.1, so there is no problem https://github.com/yegor256/netbout/blob/7ee6b0df8c0da559106c16dff1f9aca16311f627/.github/workflows/rake.yml#L21C7-L23C28 The reason is that faraday 2.0.0 is used during the run, but that version has a problem, we need at least 2.0.1 https://github.com/pnatashap/0pdd/actions/runs/7713145495/job/21022374123#step:4:106 |
This PR contains the following updates:
'3.0.6'
->'4.0.0'
Release Notes
sinatra/sinatra (sinatra)
v4.0.0
Compare Source
New: Add support for Rack 3 (#1857)
Require Ruby 2.7.8 as minimum Ruby version (#1993)
Breaking change: Drop support for Rack 2 (#1857)
rackup
gem installedBreaking change: Remove the
IndifferentHash
initializer (#1982)Breaking change: Disable
session_hijacking
protection by default (#1984)Breaking change: Remove
Rack::Protection::EncryptedCookie
(#1989)Rack::Session::Cookie
][Rack::Session::Cookie])v3.2.0
Compare Source
New: Add
#except
method toSinatra::IndifferentHash
(#1940)New: Use
Exception#detailed_message
to show backtrace (#1952)New: Add
Sinatra::HamlHelpers
to sinatra-contrib (#1960)Fix: Add
base64
to rack-protection runtime dependencies (#1946)Fix: Avoid open-ended dependencies for sinatra-contrib and rack-protection (#1949)
Fix: Helpful message when
Sinatra::Runner
times out (#1975)Fix: Ruby 3.3 + Bundler 2.5 compatibility (#1975)
v3.1.0
Compare Source
New: Add sass support via sass-embedded #1911 by なつき
New: Add start and stop callbacks #1913 by Jevin Sew
New: Warn on dropping sessions #1900 by Jonathan del Strother
New: Make Puma the default server #1924 by Patrik Ragnarsson
Fix: Remove use of Tilt::Cache #1922 by Jeremy Evans (allows use of Tilt 2.2.0 without deprecation warning)
Fix: rack-protection: specify rack version requirement #1932 by Patrik Ragnarsson
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.