Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#333] refactor classes to be vcs independent #330

Closed

Conversation

Doldrums
Copy link

@Doldrums Doldrums commented Apr 15, 2022

[Gitlab Support] Stage 1 - Rafactoring

@Doldrums Doldrums changed the title [#312] refactor classes to be vcs independent [#333] refactor classes to be vcs independent Apr 15, 2022
@yegor256
Copy link
Owner

@Doldrums there are merge conflict, please take a look

@yegor256
Copy link
Owner

@mbao01 ping

Arina Cheverda added 2 commits April 22, 2022 02:39
@Doldrums
Copy link
Author

Doldrums commented Apr 21, 2022

@Doldrums there are merge conflict, please take a look

done
review please

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 22, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Apr 22, 2022

@rultor merge

@Doldrums @yegor256 Oops, I failed. You can see the full log here (spent 4min)

concurrent-ruby              1.1.9    1.1.10
faraday                      1.8.0    2.2.0
faraday-excon                1.1.0    2.1.0
faraday-httpclient           1.0.1    2.0.1
faraday-net_http             1.0.1    2.0.2
faraday-net_http_persistent  1.2.0    2.0.1
faraday-patron               1.0.0    2.0.1
faraday-rack                 1.0.0    2.0.0
ffi                          1.15.4   1.15.5
haml                         5.2.1    5.2.2    = 5.2.1    default
jmespath                     1.4.0    1.6.1
mocha                        1.11.2   1.13.0   = 1.11.2   default
octokit                      4.20.0   4.22.0   = 4.20.0   default
parallel                     1.21.0   1.22.1
parser                       3.0.3.1  3.1.2.0
pdd                          0.20.6   0.20.8   = 0.20.6   default
public_suffix                4.0.6    4.0.7
rack-protection              2.1.0    2.2.0
rainbow                      3.0.0    3.1.1
rake                         13.0.3   13.0.6   = 13.0.3   default
rb-fsevent                   0.11.0   0.11.1
rubocop                      0.69.0   1.28.1   = 0.69.0   default
rubocop-rspec                1.33.0   2.10.0   = 1.33.0   default
sawyer                       0.8.2    0.9.1
sentry-raven                 3.1.1    3.1.2    = 3.1.1    default
simplecov_json_formatter     0.1.3    0.1.4
sinatra                      2.1.0    2.2.0    = 2.1.0    default
sinatra-contrib              2.1.0    2.2.0    = 2.1.0    default
slop                         4.9.1    4.9.2
sprockets                    4.0.2    4.0.3    = 4.0.2    default
test-unit                    3.4.0    3.5.3    = 3.4.0    default
unicode-display_width        1.6.1    2.1.0
xcop                         0.6.2    0.6.3    = 0.6.2    default
Some dependencies are outdated
Test config is absent
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Test config is absent
Test config is absent
Failed to open TCP connection to localhost:34024 (Cannot assign requested address - connect(2) for "localhost" port 34024)
DynamoDB Local table: ACTIVE
DynamoDB Local is running in PID 20013

File does not exist: /home/r/repo/objects/clients/gitlab

Coverage report generated for Unit Tests to /home/r/repo/coverage. 149 / 649 LOC (22.96%) covered.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
rake aborted!
Command failed with status (1)
/home/r/.ruby/gems/rake-13.0.3/exe/rake:27:in `<top (required)>'
/home/r/.ruby/bin/ruby_executable_hooks:24:in `eval'
/home/r/.ruby/bin/ruby_executable_hooks:24:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
DynamoDB Local killed in PID 20013
container 0bf01f2a11d40b244f39bb8a70e49503d84995aad0f71fa8a26390b52c2690ab is dead
Fri Apr 22 07:06:34 CEST 2022

@yegor256
Copy link
Owner

@Doldrums did you check it locally?

@Doldrums
Copy link
Author

Doldrums commented Apr 22, 2022

@yegor256
it was planned that you would leave your review comments, and we merge the original pr

@Doldrums
Copy link
Author

@mbao01 or maybe you can suggest something

@Doldrums Doldrums closed this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants